fix(profile): fix canceling modifications in the profile #15905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
approved these changes
Jul 30, 2024
| @@ -134,10 +134,6 @@ QtObject { | |||
| root.profileModule.moveLink(fromRow, toRow) | |||
| } | |||
|
|
|||
| function resetSocialLinks() { | |||
There was a problem hiding this comment.
You can remove the whole section afaics, lines 116-144
There was a problem hiding this comment.
Good point. Indeed there was a comment. I checked all those functions and they are never used. Removed
Jenkins Builds
|
jrainville
force-pushed
the
fix/cancel-profile-showcase
branch
from
75b868b
to
96cc689
Compare
jrainville
added a commit
that referenced
this pull request
Jul 30, 2024
jrainville
added a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15904
cancel.webm