fix(red-dot): fix getting the real state of the AC notification count #16024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
igor-sirotin
approved these changes
Aug 12, 2024
Fixes #16021 The problem was that the view doesn't update in a sync way, so getting the count from the view might be wrong. This fix makes it so we have to get the count from status-go twice, which is not ideal, but to fix it, we'd need a refactor of the AC view count mechanism
jrainville
force-pushed
the
fix/red-dot-mark-as-read-ac
branch
from
f3b655e
to
33698ec
Compare
caybro
approved these changes
Aug 13, 2024
|
Tests are stuck, but green. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16021
The problem was that the view doesn't update in a sync way, so getting the count from the view might be wrong.
This fix makes it so we have to get the count from status-go twice, which is not ideal, but to fix it, we'd need a refactor of the AC view count mechanism
I opened a refactor issue to address it at some point: #16023
red-dot-ac.webm