fix(community): Missing community owner token image #16134
Conversation
| @@ -983,4 +983,49 @@ QtObject { | |||
| // #15331 | |||
| return true | |||
| } | |||
|
|
|||
| function toBase64(buffer) { | |||
There was a problem hiding this comment.
Unfortunately I cannot useQt.btoa, because it produces a wrong result (different from js window.btoa).
There was a problem hiding this comment.
Hmm.. I wonder how come, this should be identical
There was a problem hiding this comment.
I'm not sure why, but it just produces a different length result.
I've written some tests (in html and qml). And toBase64 works similar to btoa.
Jenkins BuildsClick to see older builds (7)
|
friofry
force-pushed
the
ab/issue-15855-missing-images
branch
from
48d51ca
to
d4342c4
Compare
| @@ -983,4 +983,49 @@ QtObject { | |||
| // #15331 | |||
| return true | |||
| } | |||
|
|
|||
| function toBase64(buffer) { | |||
There was a problem hiding this comment.
Hmm.. I wonder how come, this should be identical
The minted token does not appear in the wallet until you restart the app. I've added a bug for this (#16173) mint_image.mp4Other tokens have a blank image because they were created before the fix |
|
@friofry all good. Can you rebase on latest master. It might fix the build issue and also to make sure it works fine on latest still. |
friofry
force-pushed
the
ab/issue-15855-missing-images
branch
from
d4342c4
to
b9c224e
Compare
What does the PR do
(!) suboptimal solution
This issue is a regression after refactoring and sending images as localhost URLs instead of base64 (which is good)
We try to create a token and pass URL as base64 image, SaveCommunityToken(protocol/communities/manager.go) fails to read it.
To keep the old format, I'm fetching image dataUrl (base64) and passing it to the API in the expected format
Affected areas
owner/master token
Architecture compliance
I admit the solution is not perfect. Ideally we should update the approach and just pass the community ID and get the image from the database. Not sure how to crop it properly though. And also update status-go (DeploymentParameters and DeployOwnerToken API endpoint)
My PR is consistent with this document: Architecture guidelines
Screenshot of functionality (including design for comparison)
collectible_img.mp4
Impact on end user
Should fix missing collectible image
How to test
Create a community and mint an owner token, make sure the image is not empty
Risk
(since minting requires paying fees)
fixes #15855