Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add debug logs for windows signing #16189

Merged
merged 2 commits into from
Aug 27, 2024
Merged

chore(ci): add debug logs for windows signing #16189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2b404f
chore(ci): add debug logs for windows signing
jakubgs Aug 26, 2024
2cf9cd6
chore(ci): add option to select timestamp server
jakubgs Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions ci/Jenkinsfile.windows
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,17 @@ pipeline {
description: 'Decides whether the mocked status-keycard-go library is built.',
defaultValue: false
)
choice(
name: 'WINDOWS_CODESIGN_TIMESTAMP_URL',
description: 'Time Stamp Authority (TSA) server for signing binaries.',
choices: [
'http://timestamp.digicert.com',
'http://timestamp.sectigo.com',
'http://timestamp.apple.com/ts01',
'http://time.certum.pl',
'https://freetsa.org',
]
)
}

options {
Expand Down Expand Up @@ -66,9 +77,9 @@ pipeline {
STATUS_CLIENT_EXE = "pkg/${utils.pkgFilename(ext: 'exe', arch: getArch())}"
/* 7zip archive filename */
STATUS_CLIENT_7Z = "pkg/${utils.pkgFilename(ext: '7z', arch: getArch())}"
/* RFC 3161 timestamping URL for DigiCert */
WINDOWS_CODESIGN_TIMESTAMP_URL = 'http://timestamp.digicert.com'
STATUS_BUILD_PROXY_STAGE_NAME = "${utils.isReleaseBuild() ? 'prod' : 'test'}"
/* Hack-fix for params not being set in env on first job run. */
WINDOWS_CODESIGN_TIMESTAMP_URL = "${params.WINDOWS_CODESIGN_TIMESTAMP_URL}"
}

stages {
Expand Down
4 changes: 2 additions & 2 deletions scripts/sign-windows-bin.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ for FILE in ${FOUND_FILES}; do
done

# Sign all the non-signed binaries. Add -debug if need be.
"${SIGNTOOL}" sign -v -fd SHA256 \
"${SIGNTOOL}" sign -v -debug -fd SHA256 \
-p "${WINDOWS_CODESIGN_PASSWORD}" \
-f "${WINDOWS_CODESIGN_PFX_PATH}" \
-tr "${WINDOWS_CODESIGN_TIMESTAMP_URL}" \
"${FILES_TO_SIGN[@]}" | dos2unix
"${FILES_TO_SIGN[@]}"

echo "Signed successfully!"