tests: use own profile link in messages so the information is not gone after 30 days #16197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
approved these changes
Aug 27, 2024
Jenkins Builds
|
antdanchenko
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Test logic is changed , instead of using pre-defined link to user profile, test now uses profile link of created account for the test. I am removing hardcoded values and improving test stability, because profile link is not unfurling (not showing display name and emoji hash) if user for this profile has not been online for 30 days (current threshold for storing info in waku)
So in short, test wont fail from now on at this screen being unable to get data from not resolved link
CI run:
