Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StatusNavigationListItem): unbreak hovering over settings menu items #16266

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

caybro
Copy link
Member

@caybro caybro commented Sep 4, 2024

What does the PR do

  • fixes regression when hover wouldn't work if the menu item contained a beta tag

Fixes #16263

Affected areas

Settings

Architecture compliance

  • I am familiar with the application architecture and agreed good practices.
    My PR is consistent with this document: Architecture guidelines

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it
Zaznam.obrazovky.z.2024-09-04.11-03-36.mp4

- fixes regression when hover wouldn't work if the menu item contained a
beta tag

Fixes #16263
@caybro caybro linked an issue Sep 4, 2024 that may be closed by this pull request
@status-im-auto
Copy link
Member

status-im-auto commented Sep 4, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2eac665 #1 2024-09-04 09:16:35 ~6 min tests/nim 📄log
✔️ 2eac665 #1 2024-09-04 09:18:15 ~8 min macos/aarch64 🍎dmg
✔️ 2eac665 #1 2024-09-04 09:21:26 ~11 min tests/ui 📄log
✔️ 2eac665 #1 2024-09-04 09:24:56 ~15 min macos/x86_64 🍎dmg
✔️ 2eac665 #1 2024-09-04 09:26:01 ~16 min linux-nix/x86_64 📦tgz
✔️ 2eac665 #1 2024-09-04 09:26:54 ~17 min linux/x86_64 📦tgz
✔️ 2eac665 #1 2024-09-04 09:35:49 ~26 min windows/x86_64 💿exe

@caybro caybro merged commit 6b8702b into master Sep 4, 2024
9 checks passed
@caybro caybro deleted the 16263-missing-hover-in-the-top-settings branch September 4, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing hover in the top settings
5 participants