Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct ticker for all peers ping #16268

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

iurimatias
Copy link
Member

Description

PR to trigger build to test status-im/status-go#5798

@status-im-auto
Copy link
Member

status-im-auto commented Sep 4, 2024

Jenkins Builds

Click to see older builds (5)
Commit #️⃣ Finished (UTC) Duration Platform Result
72ccd84 #1 2024-09-04 14:08:02 ~4 min macos/aarch64 📄log
72ccd84 #1 2024-09-04 14:08:29 ~4 min linux-nix/x86_64 📄log
72ccd84 #1 2024-09-04 14:09:11 ~5 min linux/x86_64 📄log
✔️ 72ccd84 #1 2024-09-04 14:09:56 ~6 min tests/nim 📄log
72ccd84 #1 2024-09-04 14:12:30 ~8 min macos/x86_64 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 14a408b #2 2024-09-04 14:20:12 ~6 min tests/nim 📄log
✔️ 14a408b #2 2024-09-04 14:20:21 ~6 min macos/aarch64 🍎dmg
✔️ 14a408b #2 2024-09-04 14:27:22 ~13 min tests/ui 📄log
✔️ 14a408b #2 2024-09-04 14:29:20 ~15 min linux-nix/x86_64 📦tgz
✔️ 14a408b #2 2024-09-04 14:29:30 ~15 min macos/x86_64 🍎dmg
✔️ 14a408b #2 2024-09-04 14:30:35 ~16 min linux/x86_64 📦tgz
✔️ 14a408b #2 2024-09-04 14:39:32 ~25 min windows/x86_64 💿exe
✔️ a9a7e71 #3 2024-09-06 16:06:25 ~6 min tests/nim 📄log
✔️ a9a7e71 #3 2024-09-06 16:09:44 ~9 min macos/aarch64 🍎dmg
✔️ a9a7e71 #3 2024-09-06 16:10:59 ~10 min macos/x86_64 🍎dmg
a9a7e71 #3 2024-09-06 16:13:27 ~13 min tests/ui 📄log
✔️ a9a7e71 #3 2024-09-06 16:16:15 ~16 min linux-nix/x86_64 📦tgz
✔️ a9a7e71 #3 2024-09-06 16:17:45 ~17 min linux/x86_64 📦tgz
✔️ a9a7e71 #3 2024-09-06 16:26:19 ~26 min windows/x86_64 💿exe

@anastasiyaig
Copy link
Contributor

status go cant be built

17:07:59  + make status-go
17:07:59  �[92mBuilding:�[39m status-go
17:07:59  ln: /Users/jenkins/workspace/s_macos_aarch64_package_PR-16268/vendor/status-go//.git/hooks: Not a directory
17:07:59  go: inconsistent vendoring in /Users/jenkins/workspace/s_macos_aarch64_package_PR-16268/vendor/status-go:
17:07:59  	github.com/waku-org/go-waku@v0.8.1-0.20240904134226-49eb64a27dc4: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
17:07:59  	github.com/waku-org/go-waku@v0.8.1-0.20240808103513-b96582a30bc5: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod
17:07:59  
17:07:59  	To ignore the vendor directory, use -mod=readonly or -mod=mod.
17:07:59  	To sync the vendor directory, run:
17:07:59  		go mod vendor
17:07:59  make[1]: *** [statusgo-shared-library] Error 1
17:07:59  make: *** [vendor/status-go/build/bin/libstatus.dylib] Error 2

@iurimatias

@iurimatias
Copy link
Member Author

@anastasiyaig yeah I need to update, will do shortly

@chaitanyaprem
Copy link
Collaborator

status go cant be built

17:07:59  + make status-go
17:07:59  �[92mBuilding:�[39m status-go
17:07:59  ln: /Users/jenkins/workspace/s_macos_aarch64_package_PR-16268/vendor/status-go//.git/hooks: Not a directory
17:07:59  go: inconsistent vendoring in /Users/jenkins/workspace/s_macos_aarch64_package_PR-16268/vendor/status-go:
17:07:59  	github.com/waku-org/go-waku@v0.8.1-0.20240904134226-49eb64a27dc4: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
17:07:59  	github.com/waku-org/go-waku@v0.8.1-0.20240808103513-b96582a30bc5: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod
17:07:59  
17:07:59  	To ignore the vendor directory, use -mod=readonly or -mod=mod.
17:07:59  	To sync the vendor directory, run:
17:07:59  		go mod vendor
17:07:59  make[1]: *** [statusgo-shared-library] Error 1
17:07:59  make: *** [vendor/status-go/build/bin/libstatus.dylib] Error 2

@iurimatias

i have pushed updates to status-go PR. can you take in the new version?
status-im/status-go@b2886ef

@iurimatias
Copy link
Member Author

@anastasiyaig now it's updated

@anastasiyaig
Copy link
Contributor

it works to me, no reconnections within 30 minutes, peers count is around 19-28 , stable

Copy link

@virginiabalducci virginiabalducci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, peer count has been increasing until reaching 21-23 and remaining stable during the 30 minutes of testing

@jrainville
Copy link
Member

I'm currently running this build as my main account to check if maybe this issue was related to the memory issue discussed here: #16214

I've been running the build for almost an hour and the memory used is around 1.9GB, which is standard.

I have seen spikes where it went up to 4GB, but it went back down.

I'll keep monitoring, but this is promising. It would make sense that the memory problem was related, because each time peers are reset, we do a new store node fetch, and considering we have a hundred channels, that's a lot of data being received and parsed.

@jrainville
Copy link
Member

It's now been running for about 4 hours and the memory is stable around 3.4GB. It's still pretty high, but it used to be "stable" around 5GB before.
It has spiked once when I came back from lunch, but that's because the laptop went to sleep.
Before, it could get up to 7GB and more

I would then recommmend to ship it!!!

chore_: upgrade go-waku

chore_: upgrade go-waku

chore_: upgrade go-waku

chore_: upgrade go-waku
@iurimatias iurimatias merged commit 502118e into release/2.30.x Sep 6, 2024
1 of 8 checks passed
@iurimatias iurimatias deleted the fix/keepalive-ticker-230 branch September 6, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants