-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct ticker for all peers ping #16268
Conversation
Jenkins BuildsClick to see older builds (5)
|
status go cant be built
|
@anastasiyaig yeah I need to update, will do shortly |
i have pushed updates to status-go PR. can you take in the new version? |
72ccd84
to
14a408b
Compare
@anastasiyaig now it's updated |
it works to me, no reconnections within 30 minutes, peers count is around 19-28 , stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, peer count has been increasing until reaching 21-23 and remaining stable during the 30 minutes of testing
I'm currently running this build as my main account to check if maybe this issue was related to the memory issue discussed here: #16214 I've been running the build for almost an hour and the memory used is around 1.9GB, which is standard. I have seen spikes where it went up to 4GB, but it went back down. I'll keep monitoring, but this is promising. It would make sense that the memory problem was related, because each time peers are reset, we do a new store node fetch, and considering we have a hundred channels, that's a lot of data being received and parsed. |
It's now been running for about 4 hours and the memory is stable around 3.4GB. It's still pretty high, but it used to be "stable" around 5GB before. I would then recommmend to ship it!!! |
chore_: upgrade go-waku chore_: upgrade go-waku chore_: upgrade go-waku chore_: upgrade go-waku
14a408b
to
a9a7e71
Compare
Description
PR to trigger build to test status-im/status-go#5798