fix(StatusMenu): StatusSuccessAction is not taken into account for Menu width #16357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
requested review from
igor-sirotin,
alexjba,
micieslak and
jrainville
caybro
commented
Sep 18, 2024
| @@ -67,16 +67,6 @@ Menu { | |||
| property var openHandler | |||
| property var closeHandler | |||
|
|
|||
| function checkIfEmpty() { | |||
Jenkins BuildsClick to see older builds (25)
|
jrainville
approved these changes
Sep 18, 2024
micieslak
reviewed
Sep 18, 2024
caybro
force-pushed
the
14037-statusmenu-statussuccessaction-is-not-taking-into-account-text-content-width
branch
from
f070fb7
to
091d8a3
Compare
|
i am looking at autotests now |
|
@caybro i fixed the locator and tests are working fine now. However, i found one thing that propbably is broken in this PR:
you need to create account, logout and open app again, when being on the login screen - open the accounts drop down |
…nu width - StatusSuccessAction, despite its name, is a visual item (`MenuItem` -> `AbstractButton`) which is not part of the `contentModel` but just added to the menu container - therefore we don't use a ListView but a ScrollView/Repeater instead and set the width/maxWidth manually after the menu items have been added to the layout Fixes #14037
caybro
force-pushed
the
14037-statusmenu-statussuccessaction-is-not-taking-into-account-text-content-width
branch
from
5748284
to
b049fbc
Compare
|
alright, seems one more fix is required, checking |
anastasiyaig
force-pushed
the
14037-statusmenu-statussuccessaction-is-not-taking-into-account-text-content-width
branch
from
866e4a0
to
b265427
Compare
|
its good to go now, all fixed |
anastasiyaig
approved these changes
Sep 23, 2024
caybro
deleted the
14037-statusmenu-statussuccessaction-is-not-taking-into-account-text-content-width
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
MenuItem->AbstractButton) which is not part of thecontentModelbut just added to the menu containerFixes #14037
Affected areas
Context Menus
Architecture compliance
My PR is consistent with this document: Architecture guidelines
Screenshot of functionality (including design for comparison)