refactor: make MessageContextMenu a functional component #16390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (6)
|
refactor: make MessageContextMenu a functional component refactor: make MessageContextMenu a functional component remove root store simplify signals in message context menu abstract copyToClipboard as a signal simplify code fix menu not closing on emoji reaction
iurimatias
force-pushed
the
chore/refactor_message_context2
branch
from
800db64
to
182cef3
Compare
jrainville
approved these changes
Sep 24, 2024
glitchminer
requested changes
Sep 25, 2024
|
@glitchminer this emojis thing is a regression in master itself (or at least was yesterday) cc: @anastasiyaig |
glitchminer
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Removes logic and global calls from MessageContextMenu and simplifies some of it
Affected areas
Anything with messages
Impact on end user
Functionality should remain the same
How to test
Right click on a message and test menu options, such as emoji reactions, copy message, reply to message
Risk
message context menu items not working as expected in some particular context