fix(MembersTabPanel): Buttons in the Member tab do not work #16441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move the MouseArea into `background` so that it doesn't obscure the potential action buttons - fixup SB page Fixes #16426
- got removed in a recent refactoring, restore it - when a context menu component is opened via `Global.openMenu()`, it has to be destroyed manually
Jenkins Builds
|
caybro
requested review from
jrainville,
igor-sirotin,
iurimatias and
micieslak
caybro
deleted the
16426-buttons-in-the-member-tab-do-not-work-only-opens-the-profile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
move the MouseArea into
backgroundso that it doesn't obscure the potential action buttonsfixup SB page
separate commit to fix ProfileContextMenu memory leaks
Fixes #16426
Affected areas
MembersTabPanel
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2024-10-02.15-12-51.mp4