-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
userProfile
removed from Global
singleton
#16530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from Global Closes: #16459
Jenkins Builds
|
caybro
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
micieslak
changed the title
Oct 16, 2024
userProfile
remvoed from Global
singletonuserProfile
removed from Global
singleton
caybro
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jrainville
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
This PR is a series of commits leading to removal of
userProfile
property fromGlobal.qml
. It's part of broader effort aiming making singletons stateless and backend-independent.isDisplayNameDupeOfCommunityMember
moved fromUtils
singleton toCommunitiesStore
as it calls backendConstants
to a dedicated component, explicitly dependent on a store. It makesConstant
holding really read-only, immutable data, with no references to the backend.ContactsStore.getProfileContext
simplified, no need to provide user's own public keyUserStatusContextMenu
made purely UI component, actions handling externalizedProfileHeader
made backend-independent and behavior improved - after removing icon (in a dirty state) the menu entry for removing image is not available (earlier was available and did nothing when clicked)sendModalPopup
removed fromProfileSectionStore
userProfile
context property removed from UI codePopupMenu
removedCloses: #16459
Affected areas
Multiple components, mainly those using
Global.userProfile
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide