Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CHERRYPICK)fix(@desktop/wallet): Swap transaction - Wrong copy on the tooltip of the 'Swap' button #16647

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Khushboo-dev-cpp
Copy link
Contributor

fixes #16568

What does the PR do

Fixes the tooltip text in SwapModal, doesnt show any tooltip when Swap button is shown

Affected areas

SwapModal

Architecture compliance

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it
Screen.Recording.2024-10-28.at.6.29.12.PM.mov

@Khushboo-dev-cpp Khushboo-dev-cpp requested review from Cuteivist and saledjenic and removed request for a team October 29, 2024 12:14
@status-im-auto
Copy link
Member

status-im-auto commented Oct 29, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 317adf7 #1 2024-10-29 12:22:13 ~7 min tests/nim 📄log
✔️ 317adf7 #1 2024-10-29 12:23:40 ~9 min macos/aarch64 🍎dmg
✔️ 317adf7 #1 2024-10-29 12:27:19 ~12 min tests/ui 📄log
✔️ 317adf7 #1 2024-10-29 12:32:05 ~17 min macos/x86_64 🍎dmg
✔️ 317adf7 #1 2024-10-29 12:36:06 ~21 min linux/x86_64 📦tgz
✔️ 317adf7 #1 2024-10-29 12:36:51 ~22 min linux-nix/x86_64 📦tgz
✔️ 317adf7 #1 2024-10-29 12:43:27 ~28 min windows/x86_64 💿exe

@Khushboo-dev-cpp Khushboo-dev-cpp changed the title fix(@desktop/wallet): Swap transaction - Wrong copy on the tooltip of the 'Swap' button (CHERRYPICK)fix(@desktop/wallet): Swap transaction - Wrong copy on the tooltip of the 'Swap' button Oct 29, 2024
@alaibe alaibe merged commit 3532cca into release/2.31.x Oct 29, 2024
8 checks passed
@alaibe alaibe deleted the fixRelease/16568 branch October 29, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants