Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessageContextMenuView): "Copy message" action visible in emoji reactions and profile clicks #9296

Conversation

caybro
Copy link
Member

@caybro caybro commented Jan 25, 2023

Fixes #9295

What does the PR do

hide the "Copy message (ID)" actions when in profile or emoji reactions mode

Affected areas

MessageContextMenuView

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

image

@status-im-auto
Copy link
Member

status-im-auto commented Jan 25, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 28fa2ca #1 2023-01-25 20:07:17 ~4 min imports 📄log
✔️ 28fa2ca #1 2023-01-25 20:07:22 ~4 min linux-cpp 📄log
28fa2ca #1 2023-01-25 20:18:17 ~15 min linux 📄log
✔️ 28fa2ca #1 2023-01-25 20:20:07 ~17 min macos 🍎dmg
✔️ 28fa2ca #1 2023-01-25 20:20:25 ~18 min linux-e2e 📄log
✔️ 28fa2ca #4 2023-01-25 20:29:32 ~5 min tests-nim 📄log
✔️ 28fa2ca #2 2023-01-25 20:30:17 ~10 min linux 📦tgz
✔️ 28fa2ca #1 2023-01-25 20:30:24 ~27 min windows 💿exe

Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@caybro caybro merged commit 878a7ba into master Jan 26, 2023
@caybro caybro deleted the 9295-chat-copy-message-action-visible-in-emoji-reactions-and-profile-clicks branch January 26, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chat: "Copy message" action visible in emoji reactions and profile clicks
6 participants