QR code scanner (QML component) #9464

igor-sirotin · 2023-02-06T15:27:57Z

Required for #5837

Overrides:

What does the PR do

This is a QR code scanner. Based on QZXing.

Notes:

I have an issue on MacOS, that camera loads quite long, about 5-10 seconds.
Didn't fix it yet, will try to improve it later.
I implemented a camera selector, but it didn't fully work for me.
Will try to fix it later.
I will also create a PR with changes made for QZXing library.
Currently pointing to status-im fork.

Affected areas

StatusQ

StatusQ checklist

add documentation if necessary (new component, new feature)
update sandbox app
- in case of new component, add new component page
- in case of new features, add variation to existing component page
- nice to have: add it to the demo application as well
test changes in both light and dark theme?

Screenshot of functionality (including design for comparison)

2023-02-06.18.25.23.mov

igor-sirotin · 2023-02-06T15:28:50Z

@0x-r4bbit, could you please test this un Windows?
@osmaczko , could you please test this un Linux?

status-im-auto · 2023-02-06T15:33:31Z

Jenkins Builds

Click to see older builds (105)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`4865d33`	#1	2023-02-06 15:33:31	~5 min	`imports`	📄`log`
✔️	`4865d33`	#1	2023-02-06 15:34:14	~6 min	`linux-cpp`	📄`log`
✔️	`4865d33`	#1	2023-02-06 15:34:52	~6 min	`tests-nim`	📄`log`
✖️	`4865d33`	#1	2023-02-06 15:35:16	~7 min	`linux-e2e`	📄`log`
✔️	`4865d33`	#1	2023-02-06 15:37:50	~9 min	`macos`	🍎`dmg`
❌	`4865d33`	#1	2023-02-06 15:39:33	~11 min	`linux`	📄`log`
✔️	`4865d33`	#1	2023-02-06 16:01:59	~33 min	`windows`	💿`exe`

✔️	`a183c31`	#2	2023-02-06 16:21:23	~5 min	`linux-cpp`	📄`log`
❌	`a183c31`	#2	2023-02-06 16:21:49	~6 min	`imports`	📄`log`
✔️	`a183c31`	#2	2023-02-06 16:22:00	~6 min	`tests-nim`	📄`log`
✖️	`a183c31`	#2	2023-02-06 16:22:29	~6 min	`linux-e2e`	📄`log`
✔️	`a183c31`	#2	2023-02-06 16:22:42	~6 min	`macos`	🍎`dmg`
❌	`a183c31`	#2	2023-02-06 16:24:02	~8 min	`linux`	📄`log`

✔️	`d0ac131`	#3	2023-02-06 16:38:18	~4 min	`linux-cpp`	📄`log`
❌	`d0ac131`	#3	2023-02-06 16:38:52	~5 min	`imports`	📄`log`
✔️	`d0ac131`	#3	2023-02-06 16:39:17	~5 min	`tests-nim`	📄`log`
✔️	`d0ac131`	#3	2023-02-06 16:39:59	~6 min	`macos`	🍎`dmg`
❌	`d0ac131`	#3	2023-02-06 16:44:50	~11 min	`linux`	📄`log`
✖️	`d0ac131`	#3	2023-02-06 16:45:26	~11 min	`linux-e2e`	📄`log`
✔️	`d0ac131`	#3	2023-02-06 16:57:57	~24 min	`windows`	💿`exe`

❌	`26eb226`	#4	2023-02-10 15:27:11	~4 min	`imports`	📄`log`
✔️	`26eb226`	#4	2023-02-10 15:27:45	~5 min	`linux-cpp`	📄`log`
✖️	`26eb226`	#4	2023-02-10 15:28:30	~5 min	`tests-nim`	📄`log`
❌	`26eb226`	#4	2023-02-10 15:30:14	~7 min	`macos`	📄`log`
✖️	`26eb226`	#4	2023-02-10 15:30:58	~8 min	`linux-e2e`	📄`log`
❌	`26eb226`	#4	2023-02-10 15:31:25	~8 min	`linux`	📄`log`
❌	`26eb226`	#4	2023-02-10 15:41:12	~18 min	`windows`	📄`log`

✖️	`698b0d7`	#5	2023-02-10 22:42:12	~2 min	`linux-e2e`	📄`log`
❌	`698b0d7`	#5	2023-02-10 22:42:42	~3 min	`macos`	📄`log`

✖️	`3e503e4`	#6	2023-02-10 22:45:04	~2 min	`linux-e2e`	📄`log`
❌	`3e503e4`	#6	2023-02-10 22:45:14	~2 min	`macos`	📄`log`
✔️	`3e503e4`	#6	2023-02-10 22:45:42	~2 min	`linux-cpp`	📄`log`
❌	`3e503e4`	#6	2023-02-10 22:46:18	~3 min	`linux`	📄`log`
✖️	`3e503e4`	#6	2023-02-10 22:47:27	~4 min	`tests-nim`	📄`log`
❌	`3e503e4`	#6	2023-02-10 22:47:38	~4 min	`imports`	📄`log`
❌	`3e503e4`	#6	2023-02-10 22:59:46	~16 min	`windows`	📄`log`

✔️	`b12c16a`	#7	2023-02-12 13:18:02	~3 min	`linux-cpp`	📄`log`
❌	`b12c16a`	#7	2023-02-12 13:18:52	~3 min	`windows`	📄`log`
❌	`b12c16a`	#7	2023-02-12 13:19:34	~4 min	`macos`	📄`log`
✖️	`b12c16a`	#7	2023-02-12 13:19:39	~4 min	`linux-e2e`	📄`log`
❌	`b12c16a`	#7	2023-02-12 13:20:03	~5 min	`imports`	📄`log`
✖️	`b12c16a`	#7	2023-02-12 13:20:54	~5 min	`tests-nim`	📄`log`
❌	`b12c16a`	#7	2023-02-12 13:21:36	~6 min	`linux`	📄`log`

✔️	`2cf8969`	#8	2023-02-12 13:48:41	~3 min	`linux-cpp`	📄`log`
❌	`2cf8969`	#8	2023-02-12 13:48:45	~3 min	`windows`	📄`log`
✖️	`2cf8969`	#8	2023-02-12 13:49:57	~4 min	`linux-e2e`	📄`log`
✖️	`2cf8969`	#8	2023-02-12 13:51:52	~6 min	`tests-nim`	📄`log`
✔️	`2cf8969`	#8	2023-02-12 13:52:14	~6 min	`imports`	📄`log`
❌	`2cf8969`	#8	2023-02-12 13:52:17	~6 min	`linux`	📄`log`
✔️	`2cf8969`	#8	2023-02-12 13:52:26	~6 min	`macos`	🍎`dmg`
❌	`2cf8969`	#9	2023-02-12 14:05:51	~3 min	`windows`	📄`log`
❌	`2cf8969`	#10	2023-02-12 19:49:34	~3 min	`windows`	📄`log`

✔️	`d10bcd2`	#9	2023-02-12 19:53:47	~3 min	`linux-cpp`	📄`log`
❌	`d10bcd2`	#11	2023-02-12 19:53:53	~3 min	`windows`	📄`log`
✖️	`d10bcd2`	#9	2023-02-12 19:55:05	~4 min	`linux-e2e`	📄`log`
✖️	`d10bcd2`	#9	2023-02-12 19:56:57	~6 min	`tests-nim`	📄`log`
✔️	`d10bcd2`	#9	2023-02-12 19:57:09	~6 min	`imports`	📄`log`
❌	`d10bcd2`	#9	2023-02-12 19:57:24	~6 min	`linux`	📄`log`
✔️	`d10bcd2`	#9	2023-02-12 19:57:35	~6 min	`macos`	🍎`dmg`

✔️	`d061fcc`	#10	2023-02-20 00:27:48	~3 min	`linux-cpp`	📄`log`
❌	`d061fcc`	#12	2023-02-20 00:28:57	~4 min	`windows`	📄`log`
✖️	`d061fcc`	#10	2023-02-20 00:29:46	~5 min	`linux-e2e`	📄`log`
✖️	`d061fcc`	#10	2023-02-20 00:30:23	~5 min	`tests-nim`	📄`log`
❌	`d061fcc`	#10	2023-02-20 00:31:10	~6 min	`linux`	📄`log`
✔️	`d061fcc`	#10	2023-02-20 00:31:39	~7 min	`imports`	📄`log`
✔️	`d061fcc`	#10	2023-02-20 00:33:19	~8 min	`macos`	🍎`dmg`
✔️	`d061fcc`	#11	2023-03-03 12:31:24	~47 min	`macos`	🍎`dmg`
❌	`d061fcc`	#13	2023-03-03 12:52:45	~2 hr 54 min	`windows`	📄`log`

❌	`99b6515`	#14	2023-03-06 13:25:41	~3 min	`windows`	📄`log`
❌	`99b6515`	#11	2023-03-06 13:26:39	~4 min	`linux`	📄`log`
✔️	`99b6515`	#11	2023-03-06 13:29:05	~7 min	`imports`	📄`log`
✔️	`99b6515`	#11	2023-03-06 13:29:05	~7 min	`tests-nim`	📄`log`
✔️	`99b6515`	#12	2023-03-06 13:30:45	~8 min	`macos`	🍎`dmg`
✖️	`99b6515`	#11	2023-03-06 13:39:44	~17 min	`linux-e2e`	📄`log`

❌	`b1bb4ac`	#15	2023-03-06 13:52:42	~5 min	`windows`	📄`log`
✔️	`b1bb4ac`	#12	2023-03-06 13:53:01	~5 min	`tests-nim`	📄`log`
✔️	`b1bb4ac`	#12	2023-03-06 13:54:30	~7 min	`imports`	📄`log`
✔️	`b1bb4ac`	#13	2023-03-06 13:55:48	~8 min	`macos`	🍎`dmg`
❌	`b1bb4ac`	#12	2023-03-06 13:59:09	~11 min	`linux`	📄`log`
✔️	`b1bb4ac`	#12	2023-03-06 14:03:53	~16 min	`linux-e2e`	📄`log`
❌	`b1bb4ac`	#17	2023-03-06 14:09:32	~1 min	`windows`	📄`log`
❌	`b1bb4ac`	#18	2023-03-06 14:35:24	~20 min	`windows`	📄`log`

✔️	`74d6f71`	#13	2023-03-06 14:54:14	~6 min	`imports`	📄`log`
✔️	`74d6f71`	#13	2023-03-06 14:55:12	~7 min	`tests-nim`	📄`log`
✔️	`74d6f71`	#14	2023-03-06 14:56:59	~8 min	`macos`	🍎`dmg`
❌	`74d6f71`	#13	2023-03-06 14:59:55	~11 min	`linux`	📄`log`
✔️	`74d6f71`	#13	2023-03-06 15:04:05	~15 min	`linux-e2e`	📄`log`
❌	`74d6f71`	#19	2023-03-06 15:09:48	~21 min	`windows`	📄`log`

✔️	`9372a3c`	#14	2023-03-07 13:27:23	~7 min	`tests-nim`	📄`log`
✔️	`9372a3c`	#14	2023-03-07 13:27:23	~7 min	`imports`	📄`log`
✔️	`9372a3c`	#15	2023-03-07 13:27:43	~7 min	`macos`	🍎`dmg`
✔️	`9372a3c`	#14	2023-03-07 13:33:18	~12 min	`linux`	📦`tgz`
✔️	`9372a3c`	#14	2023-03-07 13:34:32	~14 min	`linux-e2e`	📄`log`
❌	`9372a3c`	#20	2023-03-07 13:44:55	~24 min	`windows`	📄`log`
✔️	`9372a3c`	#17	2023-03-07 14:31:30	~6 min	`imports`	📄`log`
✖️	`9372a3c`	#17	2023-03-07 14:31:41	~6 min	`linux-e2e`	📄`log`
✔️	`9372a3c`	#17	2023-03-07 14:31:42	~6 min	`tests-nim`	📄`log`
✔️	`9372a3c`	#18	2023-03-07 14:32:32	~7 min	`macos`	🍎`dmg`
✔️	`9372a3c`	#17	2023-03-07 14:38:29	~13 min	`linux`	📦`tgz`

✔️	`0e0420e`	#15	2023-03-07 13:52:03	~6 min	`imports`	📄`log`
✔️	`0e0420e`	#16	2023-03-07 13:52:39	~7 min	`macos`	🍎`dmg`
✔️	`0e0420e`	#15	2023-03-07 13:52:41	~7 min	`tests-nim`	📄`log`
✖️	`0e0420e`	#15	2023-03-07 13:55:04	~9 min	`linux-e2e`	📄`log`
✔️	`0e0420e`	#15	2023-03-07 13:57:58	~12 min	`linux`	📦`tgz`
❌	`0e0420e`	#21	2023-03-07 14:04:16	~18 min	`windows`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`aceefba`	#17	2023-03-07 14:18:26	~3 min	`macos`	📄`log`
✖️	`aceefba`	#16	2023-03-07 14:18:55	~4 min	`linux-e2e`	📄`log`
❌	`aceefba`	#16	2023-03-07 14:19:25	~4 min	`linux`	📄`log`
❌	`aceefba`	#23	2023-03-07 14:19:55	~3 min	`windows`	📄`log`
✔️	`aceefba`	#16	2023-03-07 14:21:27	~6 min	`imports`	📄`log`
✔️	`aceefba`	#16	2023-03-07 14:22:14	~7 min	`tests-nim`	📄`log`

❌	`98b0a00`	#25	2023-03-07 15:30:00	~3 min	`windows`	📄`log`
✔️	`98b0a00`	#18	2023-03-07 15:32:46	~6 min	`imports`	📄`log`
✔️	`98b0a00`	#19	2023-03-07 15:33:09	~7 min	`macos`	🍎`dmg`
✔️	`98b0a00`	#18	2023-03-07 15:33:28	~7 min	`tests-nim`	📄`log`
✔️	`98b0a00`	#18	2023-03-07 15:37:52	~11 min	`linux`	📦`tgz`
✔️	`98b0a00`	#18	2023-03-07 15:39:56	~13 min	`linux-e2e`	📄`log`
✔️	`98b0a00`	#26	2023-03-07 16:04:26	~29 min	`windows`	💿`exe`

0x-r4bbit · 2023-02-06T15:36:22Z

@igor-sirotin unfortunately, I don't have a window machine

caybro

Awesome amount of work, some minor things inline

ui/app/AppLayouts/Profile/controls/SyncDeviceDelegate.qml

ui/app/AppLayouts/Profile/popups/SetupSyncingPopup.qml

ui/app/AppLayouts/Profile/popups/setupsyncing/Syncing.qml

ui/app/AppLayouts/Profile/views/SyncingView.qml

ui/nim-status-client.pro

src/app_service/service/devices/service.nim

igor-sirotin · 2023-02-06T16:18:29Z

@caybro, it seems that I pushed my changes from other branch to this PR.
I'm really sorry for this, I've removed redundant commits.
But I will use your comments and fix them in my code anyway 🙂

caybro

Looks better :)

ui/StatusQ/src/StatusQ/Components/StatusQrCodeScanner.qml

igor-sirotin · 2023-02-06T16:33:30Z

@caybro, thanks for comments, fixed that!

caybro

Cool!

osmaczko · 2023-02-07T08:21:34Z

@osmaczko , could you please test this un Linux?

It works! Although, it took a while to find the right angle 😅

qr-scanner-2023-02-07_09.16.14.mp4

osmaczko

The import check is broken because StatusQ knows nothing about DoOtherSide. This needs to be addressed, following #9125 rationale.

caybro

A big question: do we need this in DOtherSide? A better place would imho be status-desktop/ui/StatusQ/src, now that we decoupled those

cc @micieslak

richard-ramos · 2023-02-20T13:50:02Z

Very cool PR! can confirm it works on linux!
Something that we should think in adding in the future is a webcam selector, as it currently does not have a way to choose which cam to use for scanning the QR code.

Edit:
Nvm, i saw you mention:

I implemented a camera selector, but it didn't fully work for me.

Will try that feature :) (although i don't know where it is)

micieslak · 2023-02-21T08:39:41Z

Great job! It works for me from Sandbox, but unfortunately there are still problems to run the main app:


/usr/bin/ld: vendor/DOtherSide/build/lib/libDOtherSideStatic.a(DOtherSide.cpp.o): in function `dos_qguiapplication_create':
DOtherSide.cpp:(.text+0x7cc9): undefined reference to `QZXing::registerQMLTypes()'
collect2: error: ld returned 1 exit status
Error: execution of an external program failed: 'g++  @nim_status_client_linkerArgs.txt'
make: *** [Makefile:375: bin/nim_status_client] Error 1
01:00:04: The process "/usr/bin/make" exited with code 2.

I was playing a bit to solve that but so far no results. Some nim experts are needed here, I suppose...

micieslak · 2023-02-21T08:41:16Z

A big question: do we need this in DOtherSide? A better place would imho be status-desktop/ui/StatusQ/src, now that we decoupled those

cc @micieslak

If we want to use it in the main app (and we do, I suppose), we need to compile it via DOtherSide for the main app. At least I can't see any better solution for now.

caybro · 2023-02-21T12:33:38Z

Definitely needs a rebase

richard-ramos · 2023-03-06T13:49:13Z

This should build in Linux now!

caybro · 2023-03-06T14:08:45Z

This should build in Linux now!

Nope...

[2023-03-06T13:59:07.606Z] ERROR: ldd outputLine: "libodbc.so.2 => not found"

[2023-03-06T13:59:07.606Z] ERROR: for binary: "/opt/qt/5.15.2/gcc_64/plugins/sqldrivers/libqsqlodbc.so"

[2023-03-06T13:59:07.606Z] ERROR: Please ensure that all libraries can be found by ldd. Aborting.

I don't know what on earth needs a Qt ODBC driver but it's not found

richard-ramos · 2023-03-06T15:06:55Z

Interestingly enough, if I execute ldd in ./bin/nim_status_client, I get the following list of libraries:

        linux-vdso.so.1 (0x00007ffdb69eb000)
        libcrypto.so.3 => /lib/x86_64-linux-gnu/libcrypto.so.3 (0x00007fb91ec54000)
        libssl.so.3 => /lib/x86_64-linux-gnu/libssl.so.3 (0x00007fb91ebb0000)
        libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007fb91eb3a000)
        libQt5QuickControls2.so.5 => not found
        libQt5Quick.so.5 => /lib/x86_64-linux-gnu/libQt5Quick.so.5 (0x00007fb91e5c0000)
        libQt5Qml.so.5 => /lib/x86_64-linux-gnu/libQt5Qml.so.5 (0x00007fb91e134000)
        libQt5Multimedia.so.5 => not found
        libQt5Network.so.5 => /lib/x86_64-linux-gnu/libQt5Network.so.5 (0x00007fb91df83000)
        libQt5Gui.so.5 => /lib/x86_64-linux-gnu/libQt5Gui.so.5 (0x00007fb91d8a5000)
        libQt5Core.so.5 => /lib/x86_64-linux-gnu/libQt5Core.so.5 (0x00007fb91d346000)
        libstatus.so.0 => not found
        libkeycard.so => not found
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fb91d25d000)
        libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fb91d033000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fb91d013000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fb91cdeb000)
        /lib64/ld-linux-x86-64.so.2 (0x00007fb9208a3000)
        libQt5QmlModels.so.5 => /lib/x86_64-linux-gnu/libQt5QmlModels.so.5 (0x00007fb91cd60000)
        libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fb91cd42000)
        libgssapi_krb5.so.2 => /lib/x86_64-linux-gnu/libgssapi_krb5.so.2 (0x00007fb91ccee000)
        libGL.so.1 => /lib/x86_64-linux-gnu/libGL.so.1 (0x00007fb91cc67000)
        libpng16.so.16 => /lib/x86_64-linux-gnu/libpng16.so.16 (0x00007fb91cc2c000)
        libharfbuzz.so.0 => /lib/x86_64-linux-gnu/libharfbuzz.so.0 (0x00007fb91cb5d000)
        libmd4c.so.0 => /lib/x86_64-linux-gnu/libmd4c.so.0 (0x00007fb91cb4b000)
        libdouble-conversion.so.3 => /lib/x86_64-linux-gnu/libdouble-conversion.so.3 (0x00007fb91cb34000)
        libicui18n.so.70 => /lib/x86_64-linux-gnu/libicui18n.so.70 (0x00007fb91c805000)
        libicuuc.so.70 => /lib/x86_64-linux-gnu/libicuuc.so.70 (0x00007fb91c60a000)
        libpcre2-16.so.0 => /lib/x86_64-linux-gnu/libpcre2-16.so.0 (0x00007fb91c580000)
        libzstd.so.1 => /lib/x86_64-linux-gnu/libzstd.so.1 (0x00007fb91c4b1000)
        libglib-2.0.so.0 => /lib/x86_64-linux-gnu/libglib-2.0.so.0 (0x00007fb91c377000)
        libkrb5.so.3 => /lib/x86_64-linux-gnu/libkrb5.so.3 (0x00007fb91c2aa000)
        libk5crypto.so.3 => /lib/x86_64-linux-gnu/libk5crypto.so.3 (0x00007fb91c27b000)
        libcom_err.so.2 => /lib/x86_64-linux-gnu/libcom_err.so.2 (0x00007fb91c275000)
        libkrb5support.so.0 => /lib/x86_64-linux-gnu/libkrb5support.so.0 (0x00007fb91c267000)
        libGLdispatch.so.0 => /lib/x86_64-linux-gnu/libGLdispatch.so.0 (0x00007fb91c1af000)
        libGLX.so.0 => /lib/x86_64-linux-gnu/libGLX.so.0 (0x00007fb91c179000)
        libfreetype.so.6 => /lib/x86_64-linux-gnu/libfreetype.so.6 (0x00007fb91c0b1000)
        libgraphite2.so.3 => /lib/x86_64-linux-gnu/libgraphite2.so.3 (0x00007fb91c08a000)
        libicudata.so.70 => /lib/x86_64-linux-gnu/libicudata.so.70 (0x00007fb91a46c000)
        libkeyutils.so.1 => /lib/x86_64-linux-gnu/libkeyutils.so.1 (0x00007fb91a465000)
        libresolv.so.2 => /lib/x86_64-linux-gnu/libresolv.so.2 (0x00007fb91a44f000)
        libX11.so.6 => /lib/x86_64-linux-gnu/libX11.so.6 (0x00007fb91a30f000)
        libbrotlidec.so.1 => /lib/x86_64-linux-gnu/libbrotlidec.so.1 (0x00007fb91a301000)
        libxcb.so.1 => /lib/x86_64-linux-gnu/libxcb.so.1 (0x00007fb91a2d7000)
        libbrotlicommon.so.1 => /lib/x86_64-linux-gnu/libbrotlicommon.so.1 (0x00007fb91a2b4000)
        libXau.so.6 => /lib/x86_64-linux-gnu/libXau.so.6 (0x00007fb91a2ac000)
        libXdmcp.so.6 => /lib/x86_64-linux-gnu/libXdmcp.so.6 (0x00007fb91a2a4000)
        libbsd.so.0 => /lib/x86_64-linux-gnu/libbsd.so.0 (0x00007fb91a28c000)
        libmd.so.0 => /lib/x86_64-linux-gnu/libmd.so.0 (0x00007fb91a27f000)

and no mention of libodbc.so

caybro · 2023-03-06T15:22:15Z

libqsqlodbc.so

But this is not the issue; you want to look at the runtime dependencies of the libqsqlodbc.so plugin, and here on my system:

ltinkl@zephyrus14:/usr/lib64/qt5/plugins/sqldrivers$ ldd libqsqlodbc.so  | grep -i odbc
	libodbc.so.2 => /lib64/libodbc.so.2 (0x00007f85ec5a4000)

caybro · 2023-03-06T15:23:25Z

In other words, this seems more like a packaging problem, where we ship all Qt plugins but some of them (namely the libqsqlodbc.so plugin which we don't even need in our app) have unsatisfied runtime deps

richard-ramos · 2023-03-06T16:30:29Z

Interesting! i tried to build the app without using the lib and i'm running into the same error!
#9753

caybro · 2023-03-06T16:44:44Z

Interesting! i tried to build the app without using the lib and i'm running into the same error! #9753

Interesting... my fresh new PR builds just fine here: #9666; others don't seem to be having this problem either

igor-sirotin requested review from 0x-r4bbit, alaibe, osmaczko, a team and glitchminer and removed request for a team February 6, 2023 15:27

caybro requested changes Feb 6, 2023

View reviewed changes

igor-sirotin force-pushed the feat/qr-code-scanner branch from 4865d33 to a183c31 Compare February 6, 2023 16:15

igor-sirotin requested a review from caybro February 6, 2023 16:18

caybro reviewed Feb 6, 2023

View reviewed changes

ui/StatusQ/src/StatusQ/Components/StatusQrCodeScanner.qml Outdated Show resolved Hide resolved

ui/StatusQ/src/StatusQ/Components/StatusQrCodeScanner.qml Outdated Show resolved Hide resolved

igor-sirotin requested a review from caybro February 6, 2023 16:33

caybro approved these changes Feb 6, 2023

View reviewed changes

osmaczko reviewed Feb 7, 2023

View reviewed changes

alaibe approved these changes Feb 8, 2023

View reviewed changes

igor-sirotin force-pushed the feat/qr-code-scanner branch from d0ac131 to 26eb226 Compare February 10, 2023 15:22

caybro reviewed Feb 10, 2023

View reviewed changes

caybro requested a review from micieslak February 10, 2023 15:58

igor-sirotin force-pushed the feat/qr-code-scanner branch 2 times, most recently from 3e503e4 to b12c16a Compare February 12, 2023 13:14

richard-ramos force-pushed the feat/qr-code-scanner branch from d10bcd2 to d061fcc Compare February 20, 2023 00:24

richard-ramos mentioned this pull request Feb 20, 2023

feat: device syncing #9482

Merged

feat(QrCodeScanner): Implemented QML component for QR code scanning

b1bb4ac

richard-ramos force-pushed the feat/qr-code-scanner branch from 99b6515 to b1bb4ac Compare March 6, 2023 13:46

fix: windows dll

74d6f71

chore: add unixodbc-dev and libpq-dev to list of dependencies (#9759)

9372a3c

richard-ramos force-pushed the feat/qr-code-scanner branch 2 times, most recently from aceefba to 9372a3c Compare March 7, 2023 14:24

use .lib extension for qzxing

98b0a00

richard-ramos merged commit 7c1c178 into master Mar 7, 2023

richard-ramos deleted the feat/qr-code-scanner branch March 7, 2023 16:08

This was referenced Mar 14, 2023

Make StatusQ a QML module #9863

Closed

Embed QR code scanner into "Sign in by syncing" workflow #9865

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

QR code scanner (QML component) #9464

QR code scanner (QML component) #9464

igor-sirotin commented Feb 6, 2023 •

edited

Loading

igor-sirotin commented Feb 6, 2023

status-im-auto commented Feb 6, 2023 •

edited

Loading

0x-r4bbit commented Feb 6, 2023

caybro left a comment

igor-sirotin commented Feb 6, 2023

caybro left a comment

igor-sirotin commented Feb 6, 2023

caybro left a comment

osmaczko commented Feb 7, 2023 •

edited

Loading

osmaczko left a comment

caybro left a comment

richard-ramos commented Feb 20, 2023 •

edited

Loading

micieslak commented Feb 21, 2023

micieslak commented Feb 21, 2023

caybro commented Feb 21, 2023

richard-ramos commented Mar 6, 2023

caybro commented Mar 6, 2023

richard-ramos commented Mar 6, 2023

caybro commented Mar 6, 2023

caybro commented Mar 6, 2023

richard-ramos commented Mar 6, 2023

caybro commented Mar 6, 2023

QR code scanner (QML component) #9464

QR code scanner (QML component) #9464

Conversation

igor-sirotin commented Feb 6, 2023 • edited Loading

What does the PR do

Affected areas

StatusQ checklist

Screenshot of functionality (including design for comparison)

igor-sirotin commented Feb 6, 2023

status-im-auto commented Feb 6, 2023 • edited Loading

Jenkins Builds

0x-r4bbit commented Feb 6, 2023

caybro left a comment

Choose a reason for hiding this comment

igor-sirotin commented Feb 6, 2023

caybro left a comment

Choose a reason for hiding this comment

igor-sirotin commented Feb 6, 2023

caybro left a comment

Choose a reason for hiding this comment

osmaczko commented Feb 7, 2023 • edited Loading

osmaczko left a comment

Choose a reason for hiding this comment

caybro left a comment

Choose a reason for hiding this comment

richard-ramos commented Feb 20, 2023 • edited Loading

micieslak commented Feb 21, 2023

micieslak commented Feb 21, 2023

caybro commented Feb 21, 2023

richard-ramos commented Mar 6, 2023

caybro commented Mar 6, 2023

richard-ramos commented Mar 6, 2023

caybro commented Mar 6, 2023

caybro commented Mar 6, 2023

richard-ramos commented Mar 6, 2023

caybro commented Mar 6, 2023

igor-sirotin commented Feb 6, 2023 •

edited

Loading

status-im-auto commented Feb 6, 2023 •

edited

Loading

osmaczko commented Feb 7, 2023 •

edited

Loading

richard-ramos commented Feb 20, 2023 •

edited

Loading