Fixed changing device name #9921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
force-pushed
the
fix/issue-9584-set-device-name
branch
2 times, most recently
from
4247e56
to
94e6918
Compare
Jenkins BuildsClick to see older builds (26)
|
caybro
reviewed
Mar 16, 2023
caybro
reviewed
Mar 20, 2023
ui/app/AppLayouts/Profile/popups/SyncDeviceCustomizationPopup.qml
Outdated
Show resolved
Hide resolved
caybro
approved these changes
Mar 20, 2023
igor-sirotin
force-pushed
the
fix/issue-9584-set-device-name
branch
from
46497ff
to
3dcc712
Compare
mprakhov
reviewed
Mar 20, 2023
| # Once we get more info from `status-go` we may emit success/failed signal from here. | ||
| discard status_installations.setInstallationMetadata(installationId, name, hostOs) | ||
| let response = status_installations.setInstallationName(installationId, name) |
There was a problem hiding this comment.
shouldn't it be in the try block?
| if response.error != nil: | ||
| let e = Json.decode($response.error, RpcError) | ||
| error "error: ", errorDescription = e.message | ||
| discard |
There was a problem hiding this comment.
should we do a return here?
Or discard won't execute code after?
|
@mprakhov thanks for review! |
igor-sirotin
force-pushed
the
fix/issue-9584-set-device-name
branch
from
f0ca079
to
bd76b22
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9584
Requires status-im/status-go#3294
What does the PR do
Now it's possible to change device name :)
2023-03-16.21.16.41.mov