fix_: tests, address pr comments

cmd/lint-panics/analyzer/testdata/src/functions/pointers.go

@@ -0,0 +1,21 @@
+package functions
+
+import (
+	"common"
+)
+
+func init() {
+	runAsync(ok)
+	runAsyncOk(ok)
+}
+
+func runAsync(fn func()) {
+	go fn() // want "missing defer call to LogOnPanic"
+}
+
+func runAsyncOk(fn func()) {
+	go func() {
+		defer common.LogOnPanic()
+		fn()
+	}()
+}

cmd/lint-panics/gopls/client.go → cmd/lint-panics/gopls/dummy_client.go

@@ -13,90 +13,69 @@ type DummyClient struct {
 }
 
 func NewDummyClient(logger *zap.Logger) *DummyClient {
+	if logger == nil {
+		logger = zap.NewNop()
+	}
 	return &DummyClient{
-		logger: nil, //logger.Named("client"),
+		logger: logger,
 	}
 }
 
 func (d *DummyClient) Progress(ctx context.Context, params *protocol.ProgressParams) (err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: Progress", zap.Any("params", params))
-	}
+	d.logger.Debug("client: Progress", zap.Any("params", params))
 	return
 }
 func (d *DummyClient) WorkDoneProgressCreate(ctx context.Context, params *protocol.WorkDoneProgressCreateParams) (err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: WorkDoneProgressCreate")
-	}
+	d.logger.Debug("client: WorkDoneProgressCreate")
 	return nil
 }
 
 func (d *DummyClient) LogMessage(ctx context.Context, params *protocol.LogMessageParams) (err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: LogMessage", zap.Any("message", params))
-	}
+	d.logger.Debug("client: LogMessage", zap.Any("message", params))
 	return nil
 }
 
 func (d *DummyClient) PublishDiagnostics(ctx context.Context, params *protocol.PublishDiagnosticsParams) (err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: PublishDiagnostics")
-	}
+	d.logger.Debug("client: PublishDiagnostics")
 	return nil
 }
 
 func (d *DummyClient) ShowMessage(ctx context.Context, params *protocol.ShowMessageParams) (err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: ShowMessage", zap.Any("message", params))
-	}
+	d.logger.Debug("client: ShowMessage", zap.Any("message", params))
 	return nil
 }
 
 func (d *DummyClient) ShowMessageRequest(ctx context.Context, params *protocol.ShowMessageRequestParams) (result *protocol.MessageActionItem, err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: ShowMessageRequest", zap.Any("message", params))
-	}
+	d.logger.Debug("client: ShowMessageRequest", zap.Any("message", params))
 	return nil, nil
 }
 
 func (d *DummyClient) Telemetry(ctx context.Context, params interface{}) (err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: Telemetry")
-	}
+	d.logger.Debug("client: Telemetry")
 	return nil
 }
 
 func (d *DummyClient) RegisterCapability(ctx context.Context, params *protocol.RegistrationParams) (err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: RegisterCapability")
-	}
+	d.logger.Debug("client: RegisterCapability")
 	return nil
 }
 
 func (d *DummyClient) UnregisterCapability(ctx context.Context, params *protocol.UnregistrationParams) (err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: UnregisterCapability")
-	}
+	d.logger.Debug("client: UnregisterCapability")
 	return nil
 }
 
 func (d *DummyClient) ApplyEdit(ctx context.Context, params *protocol.ApplyWorkspaceEditParams) (result bool, err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: ApplyEdit")
-	}
+	d.logger.Debug("client: ApplyEdit")
 	return false, nil
 }
 
 func (d *DummyClient) Configuration(ctx context.Context, params *protocol.ConfigurationParams) (result []interface{}, err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: Configuration")
-	}
+	d.logger.Debug("client: Configuration")
 	return nil, nil
 }
 
 func (d *DummyClient) WorkspaceFolders(ctx context.Context) (result []protocol.WorkspaceFolder, err error) {
-	if d.logger != nil {
-		d.logger.Debug("client: WorkspaceFolders")
-	}
+	d.logger.Debug("client: WorkspaceFolders")
 	return nil, nil
 }

cmd/lint-panics/gopls/gopls.go

@@ -34,7 +34,7 @@ func NewGoplsClient(ctx context.Context, logger *zap.Logger, rootDir string) *Co
 
 	client := NewDummyClient(logger)
 
-	// Create a JSON-RPC connection using stdin and stdout
+	// Step 1: Create a JSON-RPC connection using stdin and stdout
 	gopls.cmd = exec.Command("gopls", "serve")
 
 	stdin, err := gopls.cmd.StdinPipe()
@@ -60,8 +60,10 @@ func NewGoplsClient(ctx context.Context, logger *zap.Logger, rootDir string) *Co
 		stdout: stdout,
 	})
 
+	// Step 2: Create a client for the running gopls server
 	ctx, gopls.conn, gopls.server = protocol.NewClient(ctx, client, stream, logger)
 
+	// Step 3: Initialize the gopls server
 	initParams := protocol.InitializeParams{
 		RootURI: uri.From("file", "", rootDir, "", ""),
 		InitializationOptions: map[string]interface{}{
@@ -75,7 +77,7 @@ func NewGoplsClient(ctx context.Context, logger *zap.Logger, rootDir string) *Co
 		panic(err)
 	}
 
-	// Step 2: Send 'initialized' notification
+	// Step 4: Send 'initialized' notification
 	err = gopls.server.Initialized(ctx, &protocol.InitializedParams{})
 	if err != nil {
 		logger.Error("Error during initialized", zap.Error(err))

cmd/lint-panics/utils/utils.go

@@ -1,7 +1,6 @@
 package utils
 
 import (
-	gotoken "go/token"
 	"strconv"
 
 	"fmt"
@@ -11,10 +10,6 @@ import (
 	"go.uber.org/zap/zapcore"
 )
 
-func PositionURI(pos gotoken.Position) string {
-	return URI(pos.Filename, pos.Line)
-}
-
 func URI(path string, line int) string {
 	return path + ":" + strconv.Itoa(line)
 }