Skip to content

Commit

Permalink
chore!: try to fetch both teams from github
Browse files Browse the repository at this point in the history
  • Loading branch information
siddarthkay committed Oct 1, 2024
1 parent a85f68c commit be28875
Showing 1 changed file with 68 additions and 14 deletions.
82 changes: 68 additions & 14 deletions .github/workflows/breaking-change-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
check_breaking_change:
runs-on: ubuntu-latest
steps:
- name: Check for breaking_change label
- name: Check for breaking change label
id: check_label
uses: actions/github-script@v6
with:
Expand All @@ -30,20 +30,50 @@ jobs:
issue_number: context.issue.number,
});
const hasBreakingChange = labels.some(label => label.name === 'breaking change');
console.log(`Has breaking_change label: ${hasBreakingChange}`);
console.log(`Has breaking change label: ${hasBreakingChange}`);
return hasBreakingChange;
- name: Fetch QA team members
if: steps.check_label.outputs.result == 'true'
id: fetch_qa_teams
uses: actions/github-script@v6
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
async function getTeamMembers(teamSlug) {
const response = await github.request('GET /orgs/status-im/teams/{team_slug}/members', {
headers: {
'X-GitHub-Api-Version': '2022-11-28',
'"Authorization: Bearer ${{secrets.GITHUB_TOKEN}}"'
}
});
return response.data.map(member => member.login);
}
const mobileQA = await getTeamMembers('mobile-qa');
const desktopQA = await getTeamMembers('desktop-qa');
console.log('Mobile QA team:', mobileQA);
console.log('Desktop QA team:', desktopQA);
core.setOutput('mobile_qa', mobileQA.join(','));
core.setOutput('desktop_qa', desktopQA.join(','));
- name: Request QA reviews
if: steps.check_label.outputs.result == 'true'
uses: actions/github-script@v6
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const mobileQA = '${{ steps.fetch_qa_teams.outputs.mobile_qa }}'.split(',');
const desktopQA = '${{ steps.fetch_qa_teams.outputs.desktop_qa }}'.split(',');
const reviewers = [...mobileQA, ...desktopQA];
await github.rest.pulls.requestReviewers({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.issue.number,
reviewers: ['churik']
reviewers: reviewers
});
- name: Check QA approvals
Expand All @@ -59,30 +89,54 @@ jobs:
pull_number: context.issue.number,
});
const desktopQAApproved = reviews.some(review =>
review.state === 'APPROVED' && review.user.login.includes('desktop-qa')
);
const mobileQA = '${{ steps.fetch_qa_teams.outputs.mobile_qa }}'.split(',');
const desktopQA = '${{ steps.fetch_qa_teams.outputs.desktop_qa }}'.split(',');
const mobileQAApproved = reviews.some(review =>
review.state === 'APPROVED' && review.user.login.includes('mobile-qa')
review.state === 'APPROVED' && mobileQA.includes(review.user.login)
);
const desktopQAApproved = reviews.some(review =>
review.state === 'APPROVED' && desktopQA.includes(review.user.login)
);
console.log(`Desktop QA approved: ${desktopQAApproved}`);
console.log(`Mobile QA approved: ${mobileQAApproved}`);
console.log(`Desktop QA approved: ${desktopQAApproved}`);
core.setOutput('mobile-qa-approved', mobileQAApproved);
core.setOutput('desktop-qa-approved', desktopQAApproved);
return desktopQAApproved && mobileQAApproved;
return mobileQAApproved && desktopQAApproved;
- name: Block PR if conditions not met
if: steps.check_label.outputs.result == 'true' && steps.check_approvals.outputs.result != 'true'
uses: actions/github-script@v6
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
await github.rest.pulls.createReview({
const mobileQAApproved = ${{ steps.check_approvals.outputs.mobile-qa-approved }};
const desktopQAApproved = ${{ steps.check_approvals.outputs.desktop-qa-approved }};
let message = 'This PR has the breaking change label and requires approval from both mobile-qa and desktop-qa teams before it can be merged.\n\n';
if (!mobileQAApproved && !desktopQAApproved) {
message += 'Both mobile-qa and desktop-qa teams have not approved this PR yet.';
} else if (!mobileQAApproved) {
message += 'The mobile-qa team has not approved this PR yet.';
} else if (!desktopQAApproved) {
message += 'The desktop-qa team has not approved this PR yet.';
}
await github.rest.checks.create({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.issue.number,
event: 'REQUEST_CHANGES',
body: 'This PR has the breaking_change label and requires approval from both @status-im/desktop-qa and @status-im/mobile-qa teams before it can be merged.'
name: 'QA Approval Check',
head_sha: context.payload.pull_request.head.sha,
status: 'completed',
conclusion: 'failure',
output: {
title: 'QA Approval Required',
summary: message
}
});
- name: Allow PR merge if conditions are met
Expand All @@ -96,5 +150,5 @@ jobs:
repo: context.repo.repo,
pull_number: context.issue.number,
event: 'APPROVE',
body: 'All conditions have been met. This PR can now be merged.'
body: 'Breaking changes have been tested by Mobile and Desktop QA teams. This PR can now be merged.'
});

0 comments on commit be28875

Please sign in to comment.