Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: use zap logger as request logger #5991

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

osmaczko
Copy link
Contributor

iterates: #6002

@osmaczko osmaczko force-pushed the chore/use-zap-logger-as-request-logger branch from 0f2acbb to e1058df Compare October 24, 2024 21:50
@status-im-auto
Copy link
Member

status-im-auto commented Oct 24, 2024

Jenkins Builds

Click to see older builds (21)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 0f2acbb #1 2024-10-24 21:52:32 ~3 min tests 📄log
✔️ 0f2acbb #1 2024-10-24 21:54:04 ~5 min linux 📦zip
✔️ 0f2acbb #1 2024-10-24 21:54:10 ~5 min ios 📦zip
✔️ 0f2acbb #1 2024-10-24 21:55:06 ~6 min android 📦aar
✔️ 0f2acbb #1 2024-10-24 21:55:33 ~6 min tests-rpc 📄log
✖️ e1058df #2 2024-10-24 21:54:57 ~2 min tests 📄log
✔️ e1058df #2 2024-10-24 21:59:16 ~5 min ios 📦zip
✔️ e1058df #2 2024-10-24 21:59:22 ~5 min linux 📦zip
✔️ e1058df #2 2024-10-24 22:01:31 ~6 min android 📦aar
✔️ e1058df #2 2024-10-24 22:01:52 ~6 min tests-rpc 📄log
✔️ e4dcd14 #3 2024-10-25 06:44:00 ~5 min linux 📦zip
✔️ e4dcd14 #3 2024-10-25 06:44:14 ~5 min ios 📦zip
✔️ e4dcd14 #3 2024-10-25 06:45:11 ~6 min android 📦aar
✖️ e4dcd14 #3 2024-10-25 06:45:30 ~6 min tests-rpc 📄log
✔️ e4dcd14 #3 2024-10-25 07:13:17 ~34 min tests 📄log
✖️ c2d5c23 #4 2024-10-25 09:43:13 ~1 min tests 📄log
✔️ c2d5c23 #4 2024-10-25 09:46:45 ~5 min ios 📦zip
✔️ c2d5c23 #4 2024-10-25 09:46:52 ~5 min linux 📦zip
✔️ c2d5c23 #4 2024-10-25 09:47:45 ~6 min tests-rpc 📄log
✔️ c2d5c23 #4 2024-10-25 09:47:51 ~6 min android 📦aar
✖️ c2d5c23 #5 2024-10-25 11:24:43 ~1 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 54fdf50 #5 2024-10-28 10:13:44 ~5 min linux 📦zip
✔️ 54fdf50 #5 2024-10-28 10:13:54 ~5 min ios 📦zip
✔️ 54fdf50 #5 2024-10-28 10:14:21 ~5 min tests-rpc 📄log
✔️ 54fdf50 #5 2024-10-28 10:14:35 ~5 min android 📦aar
✔️ 54fdf50 #6 2024-10-28 10:41:25 ~32 min tests 📄log
✔️ 54fdf50 #6 2024-10-28 21:00:05 ~5 min linux 📦zip
✔️ 54fdf50 #6 2024-10-28 21:00:38 ~6 min ios 📦zip
✔️ 54fdf50 #6 2024-10-28 21:00:55 ~6 min tests-rpc 📄log
✔️ 54fdf50 #6 2024-10-28 21:01:03 ~6 min android 📦aar
✔️ 54fdf50 #7 2024-10-28 21:28:27 ~33 min tests 📄log
✔️ 2205723 #1 2024-10-28 21:04:29 ~6 min macos 📦zip
✔️ 2205723 #7 2024-10-28 21:05:47 ~5 min linux 📦zip
✔️ 2205723 #1 2024-10-28 21:06:31 ~8 min macos 📦zip
✔️ 2205723 #7 2024-10-28 21:07:15 ~6 min tests-rpc 📄log
✔️ 2205723 #7 2024-10-28 21:07:23 ~6 min ios 📦zip
✔️ 2205723 #7 2024-10-28 21:07:37 ~6 min android 📦aar
✖️ 2205723 #1 2024-10-28 21:08:42 ~10 min windows 📦zip
✔️ 2205723 #8 2024-10-28 22:02:38 ~34 min tests 📄log

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.47%. Comparing base (2ced83a) to head (2205723).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
logutils/requestlog/request_log.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5991      +/-   ##
===========================================
- Coverage    47.50%   47.47%   -0.04%     
===========================================
  Files          850      850              
  Lines       139515   139522       +7     
===========================================
- Hits         66275    66236      -39     
- Misses       65450    65484      +34     
- Partials      7790     7802      +12     
Flag Coverage Δ
functional 10.17% <0.00%> (-0.06%) ⬇️
unit 46.96% <92.85%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
logutils/logrotation.go 100.00% <100.00%> (ø)
mobile/status_request_log.go 91.66% <100.00%> (+1.19%) ⬆️
logutils/requestlog/request_log.go 89.47% <83.33%> (+5.47%) ⬆️

... and 28 files with indirect coverage changes

@osmaczko osmaczko force-pushed the chore/use-zap-logger-as-request-logger branch from e1058df to e4dcd14 Compare October 25, 2024 06:38
mobile/status_request_log.go Outdated Show resolved Hide resolved
mobile/status_request_log.go Show resolved Hide resolved
vendor/github.com/ethereum/go-ethereum/rpc/service.go Outdated Show resolved Hide resolved
@osmaczko osmaczko force-pushed the chore/use-zap-logger-as-request-logger branch from c2d5c23 to 54fdf50 Compare October 28, 2024 10:08
@osmaczko osmaczko requested a review from qfrank October 28, 2024 10:13
@osmaczko osmaczko force-pushed the feat/categorized-logging branch 3 times, most recently from fdba6cb to df082f6 Compare October 28, 2024 20:17
Base automatically changed from feat/categorized-logging to develop October 28, 2024 20:54
iterates: status-im/status-desktop#16536
@osmaczko osmaczko force-pushed the chore/use-zap-logger-as-request-logger branch from 54fdf50 to 2205723 Compare October 28, 2024 20:57
@osmaczko osmaczko merged commit 2c1b321 into develop Oct 29, 2024
17 of 21 checks passed
@osmaczko osmaczko deleted the chore/use-zap-logger-as-request-logger branch October 29, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants