Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📱Save an address by scanning it's QR code #19766

Closed
Tracked by #18568
shivekkhurana opened this issue Apr 23, 2024 · 0 comments · Fixed by #20353
Closed
Tracked by #18568

📱Save an address by scanning it's QR code #19766

shivekkhurana opened this issue Apr 23, 2024 · 0 comments · Fixed by #20353
Assignees
@mohsen-ghafouri
Labels
feature feature requests wallet: Settings All issues for the mobile wallet settings
Milestone
2.30.0

Comments

@shivekkhurana
Copy link
Contributor

shivekkhurana commented Apr 23, 2024 •
edited
Loading

Feature Issue

User Story

📱 As a user,
I should be able to save an address by scanning an address QR code

Acceptance Criteria

Screen Description Acceptance Criteria
image On pressing the scan button, the app should open a scanner 1. On scanning a valid address, the address should be saved
2. The app should be able to scan both legacy and multi-chain addresses
image Success toast 1. If an address is identified, it should be saved
2. User should be redirected to the saved addresses screen, a success should be toasted

Notes

Figma Flow: https://www.figma.com/file/hLFPHYnuM0pOzgiabtqQ6k/Descoped-Wallet-settings-for-Mobile?type=design&node-id=80-168619&mode=design&t=DJXQe9W3moVlqy0c-4

We don't have error paths in the descoped design. Need to check with UI team if this is needed.
@shivekkhurana shivekkhurana mentioned this issue Apr 23, 2024
Closed
12 tasks
@ibrkhalil ibrkhalil mentioned this issue Apr 25, 2024
Closed
@smohamedjavid smohamedjavid added this to the 2.30.0 Beta milestone May 21, 2024
@smohamedjavid smohamedjavid added wallet: Settings All issues for the mobile wallet settings T:Mobile Wallet Settings labels May 21, 2024
@smohamedjavid smohamedjavid moved this to Next Iteration in Status Desktop/Mobile Board May 30, 2024
@mohsen-ghafouri mohsen-ghafouri self-assigned this May 31, 2024
@mohsen-ghafouri mohsen-ghafouri moved this from Next Iteration to In Progress in Status Desktop/Mobile Board May 31, 2024
@mohsen-ghafouri mohsen-ghafouri moved this from In Progress to Iteration Backlog in Status Desktop/Mobile Board May 31, 2024
@mohsen-ghafouri mohsen-ghafouri moved this from Iteration Backlog to In Progress in Status Desktop/Mobile Board Jun 4, 2024
@mohsen-ghafouri mohsen-ghafouri mentioned this issue Jun 5, 2024
Merged
mohsen-ghafouri added a commit that referenced this issue Jun 5, 2024
@mohsen-ghafouri
[#19766] feat: save an address by scanning it's QR code (#20353)
2da6d9d
@github-project-automation github-project-automation bot moved this from In Progress to Done in Status Desktop/Mobile Board Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohsen-ghafouri mohsen-ghafouri

Labels
feature feature requests wallet: Settings All issues for the mobile wallet settings
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.30.0
Development

Successfully merging a pull request may close this issue.

[#19766] feat: save an address by scanning it's QR code status-im/status-mobile
4 participants
@shivekkhurana @smohamedjavid @ibrkhalil @mohsen-ghafouri