[WIP] Share Tab (Shell Profile Only) #15528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
force-pushed
the
13439-implement-share-in-shell
branch
from
5e0bba0
to
6b00bd1
Compare
Jenkins BuildsClick to see older builds (130)
|
siddarthkay
force-pushed
the
13439-implement-share-in-shell
branch
from
8812845
to
3d1b070
Compare
siddarthkay
force-pushed
the
13439-implement-share-in-shell
branch
3 times, most recently
from
324831b
to
0975786
Compare
siddarthkay
requested review from
ibrkhalil,
ilmotta,
cammellos,
flexsurfer,
Parveshdhull and
J-Son89
siddarthkay
force-pushed
the
13439-implement-share-in-shell
branch
from
a87fc62
to
e52e150
Compare
flexsurfer
reviewed
Mar 31, 2023
| (defn screen-container | ||
| [window-width top bottom] | ||
| {:flex 1 | ||
| :width window-width |
There was a problem hiding this comment.
:width window-width why this needed?
There was a problem hiding this comment.
we need to set this in the event the container has no content, for example when you switch to wallet tab since there is no width the view looks like this if I remove this code :
There was a problem hiding this comment.
seems this use of window-width is still here? this should be adjusted too if possible 👍
There was a problem hiding this comment.
This is just for the wallet-tab at the moment, it will go away once that comes in
ilmotta
reviewed
Mar 31, 2023
siddarthkay
force-pushed
the
13439-implement-share-in-shell
branch
from
6dd9897
to
5111d2f
Compare
siddarthkay
force-pushed
the
13439-implement-share-in-shell
branch
from
8c7d057
to
fc677da
Compare
J-Son89
reviewed
Apr 4, 2023
J-Son89
reviewed
Apr 4, 2023
J-Son89
approved these changes
Apr 4, 2023
It is a blurred overlay currently, It may look like a solid background because of the dark starting screen, try checking the share view on some other screen, maybe messaging screen, it looks like this :
|
J-Son89
reviewed
Apr 4, 2023
siddarthkay
force-pushed
the
13439-implement-share-in-shell
branch
from
ffa4412
to
95cb4fb
Compare
|
hey @siddarthkay i see its approved and tested, so it's not a draft? |
I found a critical issue and hence moved this PR to draft since it is work in progress. |
flexsurfer
changed the title
…tatus-im/status-mobile into 13439-implement-share-in-shell
…ub.com/status-im/status-mobile into 13439-implement-share-in-shell" This reverts commit caf53a2, reversing changes made to ffa4412.
|
closing in favour of : #15782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #13439
note : only profile tab, it makes sense to introduce wallet tab once the wallet redesign is done, I am sure a lot of things will change post wallet redesign.
Screen record of how it work :
Screen.Recording.2023-03-31.at.1.40.53.PM.mov
status: ready