Add 'Test Networks Enabled' option in settings #17879
Conversation
ajayesivan
force-pushed
the
add-test-networks-enabled-setting
branch
from
05abe42
to
6bf782f
Compare
| @@ -242,6 +242,7 @@ | |||
|
|
|||
| (defn- internal-discover-view | |||
| [params] | |||
| (rf/dispatch [:fetch-contract-communities]) | |||
There was a problem hiding this comment.
This dispatch is not related to the Test Networks Enabled option.
Just added back the curated communities fetch event dispatch that got removed in a previous PR.
ajayesivan
changed the title
ajayesivan
requested review from
ilmotta,
cammellos,
flexsurfer,
J-Son89,
jo-mut and
FFFra
Jenkins BuildsClick to see older builds (48)
|
| @@ -56,6 +57,10 @@ | |||
| {:profile.settings/webview-debug-changed value} | |||
| (profile-update :webview-debug (boolean value) {}))) | |||
|
|
|||
| (rf/reg-event-fx :profile.settings/change-test-networks-enabled | |||
There was a problem hiding this comment.
is it possible to add a simple test here? 🙏
|
@briansztamfater, @vkjr, @OmarBasem I believe we can use this for wallet test-net being enabled. Also @ajayesivan - I believe there is some corresponding UI for this where there is an orange banner at the top of the application. Should we add this here or in a follow up? 
|
| @@ -56,6 +57,10 @@ | |||
| {:profile.settings/webview-debug-changed value} | |||
| (profile-update :webview-debug (boolean value) {}))) | |||
|
|
|||
| (rf/reg-event-fx :profile.settings/change-test-networks-enabled | |||
| (fn [_ [value]] | |||
| {:fx [[:dispatch [:profile.settings/profile-update :test-networks-enabled? (boolean value) {}]]]})) | |||
There was a problem hiding this comment.
I don't see much of a need for this new event if it's just re-dispatching and passing value converted to a boolean.
We can create a more useful event, like :profile.settings/toggle-test-networks and have it read from the app db itself. So the view wouldn't even need to pass value, since that's already in the global state.
Or just consume :profile.settings/profile-update directly in the view.
modified src/status_im/ui/screens/advanced_settings/views.cljs
@@ -101,8 +101,7 @@
:accessibility-label :test-networks-enabled
:container-margin-bottom 8
:on-press
- #(re-frame/dispatch
- [:profile.settings/change-test-networks-enabled (not test-networks-enabled?)])
+ #(re-frame/dispatch [:profile.settings/toggle-test-networks])
:accessory :switch
:active test-networks-enabled?}
{:size :small
modified src/status_im2/contexts/profile/settings/events.cljs
@@ -61,6 +61,11 @@
(fn [_ [value]]
{:fx [[:dispatch [:profile.settings/profile-update :test-networks-enabled? (boolean value) {}]]]}))
+(rf/reg-event-fx :profile.settings/toggle-test-networks
+ (fn [{:keys [db]}]
+ (let [value (get-in db [:profile/profile :test-networks-enabled?])]
+ {:fx [[:dispatch [:profile.settings/profile-update :test-networks-enabled? (not value) {}]]]})))
|
@ajayesivan, why don't we make logout automatic here? |
ajayesivan
force-pushed
the
add-test-networks-enabled-setting
branch
2 times, most recently
from
443ae8b
to
29d99f0
Compare
ajayesivan
force-pushed
the
add-test-networks-enabled-setting
branch
6 times, most recently
from
b62f6b6
to
4e29983
Compare
ajayesivan
force-pushed
the
add-test-networks-enabled-setting
branch
3 times, most recently
from
81a9fc1
to
f5ec2ac
Compare
@J-Son89 On desktop they are not logging out. I mentioned it as a test note to confirm the toggle is working properly. |
okay that's fine for now - Desktop has setup it up that the login initialisation calls are repeated (at least for wallet) so that the tokens etc are on testnet. It might be good for us even to prompt/alert the user that they should logout/login again to avoid confusion among ourselves |
ajayesivan
force-pushed
the
add-test-networks-enabled-setting
branch
from
f5ec2ac
to
bb5c080
Compare
ajayesivan
force-pushed
the
add-test-networks-enabled-setting
branch
from
bb5c080
to
a26358c
Compare
|
hi, @ajayesivanThank you for the PR. Currently, I don't have any issues. I just have a few questions to ensure it should work so for now ISSUE 1: ETH assets unavailable when test mode activated with mainnet or deactivated with goerli network enabledSteps:
Actual result:Upon opening ETH account, the assets are not visible Expected result:Potential solution:
|
|
@ajayesivan Is this an issue or a temporary behavior until the wallet setting screen, as mentioned by @J-Son89 in this comment, gets implemented? |
|
ISSUE 1: ETH assets unavailable when test mode activated with mainnet or deactivated with goerli network enabled This pr just adds the testnet network toggle that will make that change in Status-Go. There are a few minor adjustments we then need to make in Wallet once we have this pr merged so we will handle that in a separate issue/pr which someone from the wallet team can take 👍 |
|
@ajayesivan, you mentioned in this comment that 'This option is required to test curated communities in status.test fleet.' when I visit https://community-dapp-git-review-status-im-web.vercel.app/votes testnet (Optimism Goerli) to view the 'status.test' fleet communities, I don't see any community listed there. However, one community is fetched in the Status app in the Curated Communities section when the 'test mode' is activated. I'm a bit confused about what kind of community is being fetched into our Status app? Actual result:No communities are shown in the https://community-dapp-git-review-status-im-web.vercel.app/votes but one community is fetched in Status app in discovery page Expected result:If no communities are shown in https://community-dapp-git-review-status-im-web.vercel.app/votes , then no communities are fetched to Curated communities page |
|
Hi @VolodLytvynenko, Concerning curated communities, to retrieve test network communities, we must enable both this toggle and switch to the |
ajayesivan
force-pushed
the
add-test-networks-enabled-setting
branch
from
a26358c
to
c36f316
Compare
|
hi @ajayesivan . Thank you for the clarification. No additional issues from my side. PR is ready to be merged |
fixes: #17826
Add Test Networks Enabled toggle in Advanced Settings
Test Notes
Note: This option is required to test curated communities in
status.testfleet. This PR doesn't fix the issue logged here: #17852, additional changes are required to fully fix that.