-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wallet home loading state #20297
Conversation
Jenkins BuildsClick to see older builds (12)
|
Great work @OmarBasem! 🙌 Some questions more so for a follow up issue. On loading should we change the + account card button to a loading one of the users customization color?
Also the content tends to jump a bit going from loading to loaded. Does anyone have any suggestions for how we can improve this? Perhaps animations or identify what content on screen causes this to happen and fix that in place? |
3867441
to
c7cd8e8
Compare
@J-Son89 We can do that. It would be even better if we can go the loading state of the accounts cards directly without having that state where there is only the plus card
I noticed going from the state of having the plus icon to the accounts loading, the content gets pushed down, then when loaded pushed up. I have opened an issue to investigate these 2 problems: #20328 |
45% of end-end tests have passed
Not executed tests (1)Failed tests (26)Click to expandClass TestActivityMultipleDevicePR:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Expected to fail tests (2)Click to expandClass TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Passed tests (23)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
47% of end-end tests have passed
Not executed tests (1)Failed tests (24)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (24)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
Hey @status-im/mobile-qa, can you please check e2e? |
Hey @OmarBasem! Failed e2e are not PR related. We still experience issues on Waku side, that's why bunch of tests are failing. Ready for merge. |
0535f48
to
e49e49b
Compare
fixes: #20265
Summary
This PR fixes loading state when starting wallet. Previously it starts at 0, then goes to loading state, then displays data. Now it starts at loading state immediately.
Skipping QA as it is a simple fix.
Demo
Screen_Recording_20240603_090544_Status.mp4