Icon added to disclaimer component #20309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (20)
|
OmarBasem
approved these changes
Jun 3, 2024
| @@ -16,3 +16,6 @@ | |||
|
|
|||
| (def text | |||
| {:margin-left 8}) | |||
|
|
|||
| (def icon-container | |||
| {:align-items :flex-end :flex 1}) | |||
There was a problem hiding this comment.
I think it should be on 2 lines?
J-Son89
approved these changes
Jun 5, 2024
88% of end-end tests have passedNot executed tests (1)Failed tests (3)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (45)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
|
Hi @vkjr ! |
|
@VolodLytvynenko, I'm adding the request-manual-qa label. The changes here a minimal, but this component used on password creating and password changing screens, so can be briefly tested I think. |
VolodLytvynenko
force-pushed
the
disclaimer-icon
branch
from
4244ddb
to
1683d51
Compare
|
@vkjr Thank you for PR. No issues from my side. @Francesca-G , could you take a look at this PR? |
|
@Francesca-G, I've fixed the mentioned issues, could you please take a look again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disclaimercomponent has an icon by Figma design, but it wasn't implemented in our code. Adding it since it is needed for routing editing page.Figma link
Steps to test
Disclaimercomponentstatus: ready