-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤝 🔁 [19834] Add dapp connection flow with a basic design (#20204) #20325
🤝 🔁 [19834] Add dapp connection flow with a basic design (#20204) #20325
Conversation
Jenkins BuildsClick to see older builds (16)
|
73% of end-end tests have passed
Not executed tests (1)Failed tests (11)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Passed tests (37)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
|
@status-im/mobile-qa do E2E tests look fine to merge this PR? |
looks like e2e failed due to the delivery issue. I have rerun e2e one more time |
45% of end-end tests have passed
Not executed tests (1)Failed tests (25)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (23)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
- IDK why, trying things out
- My handler was not being called because I wrote the code in a different QR scanner
Hi @shivekkhurana ! |
- Hard coded the first account - The data item component doesn't support networks or accounts yet - The quo category component cannot show a data-item yet - Connected accept and decline button
7a33ca7
to
e81cea7
Compare
- Bring back missing event
e81cea7
to
54addc4
Compare
This feature was developed and approved here: #20204
But that branch was merged accidentally without QA. Reopening the PR again.
This branch is ready for e2e as it was already approved and fixed.