Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

Commit

Permalink
Don't return errors on logger.Sync
Browse files Browse the repository at this point in the history
Currently logger.Sync fails often (or always), reading uber-go/zap#328
seems like it's safe to ignore.
  • Loading branch information
cammellos committed Jul 24, 2019
1 parent b9a1aa9 commit 51e8c10
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion messenger.go
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,9 @@ func NewMessenger(
shutdownTasks: []func() error{
persistence.Close,
adapter.transport.Reset,
logger.Sync,
// Currently this often fails, seems like it's safe to ignore them
// https://github.com/uber-go/zap/issues/328
func() error { _ = logger.Sync; return nil },
},
logger: logger,
}
Expand Down

0 comments on commit 51e8c10

Please sign in to comment.