Make untangle available from conda-forge #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stchris
requested changes
Jul 1, 2020
There was a problem hiding this comment.
Thanks for this, I added some small suggestions.
Additionally:
- would you mind adding yourself to the CONTRIBUTORS file
- would you mind adding a line about packaging being your responsibility, perhaps with a link to your github username so people can tag you / find you?
Thanks!
Co-authored-by: Christian Stefanescu <217554+stchris@users.noreply.github.com>
Co-authored-by: Christian Stefanescu <217554+stchris@users.noreply.github.com>
Co-authored-by: Christian Stefanescu <217554+stchris@users.noreply.github.com>
Co-authored-by: Christian Stefanescu <217554+stchris@users.noreply.github.com>
|
@stchris Okay, added comment about conda maintenance to the readme and added myself to the contributors. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72
Untangle has been added to conda-forge feedstock. Adds documentation about how to install with conda.