-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update namespace TypeScript declarations #1351
Conversation
Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>
@@ -489,7 +489,7 @@ interface Namespace { | |||
empty: typeof empty; | |||
|
|||
/** | |||
* Creates an uninitialized array having the same length and data type as a provided input array. | |||
* Creates an uninitialized array having the same length as a provided input array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Planeshifter Looks like we lost part of the description in 819d2e4, as, by default, we do infer the data type from the input array.
@@ -1040,7 +1031,7 @@ interface Namespace { | |||
ones: typeof ones; | |||
|
|||
/** | |||
* Creates an array filled with ones and having the same length and data type as a provided input array. | |||
* Creates an array filled with ones and having the same length as a provided input array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment.
@@ -1892,7 +1874,7 @@ interface Namespace { | |||
zeros: typeof zeros; | |||
|
|||
/** | |||
* Creates a zero-filled array having the same length and data type as a provided input array. | |||
* Creates a zero-filled array having the same length as a provided input array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR can move forward; however, we should investigate whether we can update the descriptions of the *-like
exports to reflect that the output array data type is, by default, inferred from the input array.
I'll wait for CI to finish before merging. |
This PR