Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @stdlib/math/iter/sequences/tribonacci #1393

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

PraneGIT
Copy link
Contributor

Resolves #1331

Description

What is the purpose of this pull request?

adding the package @stdlib/math/iter/sequences/tribonacci.

The package is similar in structure as @stdlib/math/iter/sequences/fibonacci.

Package: @stdlib/math/iter/sequences/tribonacci
Alias: iterTribonacciSeq

This pull request:

  • adds the package @stdlib/math/iter/sequences/tribonacci.

Related Issues

Does this pull request have any related issues?
No.
This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@PraneGIT PraneGIT changed the title Issue #1331 add @stdlib/math/iter/sequences/tribonacci #1331 Feb 26, 2024
@PraneGIT PraneGIT changed the title add @stdlib/math/iter/sequences/tribonacci #1331 feat: add @stdlib/math/iter/sequences/tribonacci #1331 Feb 26, 2024
@PraneGIT PraneGIT changed the title feat: add @stdlib/math/iter/sequences/tribonacci #1331 feat: add @stdlib/math/iter/sequences/tribonacci Feb 26, 2024
@Jaysukh-409
Copy link
Member

@PraneGIT You should update the Copyright year from 2019 to 2024.

@Planeshifter Planeshifter self-requested a review February 27, 2024 01:17
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you @PraneGIT! Should be ready to land after CI has passed.

@Planeshifter Planeshifter merged commit fa2359f into stdlib-js:develop Feb 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/math/iter/sequences/tribonacci
4 participants