Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lapack/base/dlassq #2668

Merged
merged 15 commits into from
Jul 28, 2024
Merged

feat: add lapack/base/dlassq #2668

merged 15 commits into from
Jul 28, 2024

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Jul 26, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request add JS implementation for lapack/base/dlassq.

Related Issues

Does this pull request have any related issues?

Towards #2464

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

TODO:

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). labels Jul 26, 2024
@Pranavchiku Pranavchiku marked this pull request as ready for review July 27, 2024 04:30
@Pranavchiku Pranavchiku added the Needs Review A pull request which needs code review. label Jul 27, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jul 28, 2024
@Pranavchiku Pranavchiku added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Jul 28, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 28, 2024
kgryte
kgryte approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this, @Pranavchiku.

I ended up having to do a decent amount of clean-up. We'll want to work on reducing that moving forward.

@kgryte kgryte merged commit 8c74427 into stdlib-js:develop Jul 28, 2024
8 checks passed
@Pranavchiku
Copy link
Member Author

I am sorry for making you put in lots of efforts in PR reviews. I'll take a close look the changes you made and assure quality PRs from now.

gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@Pranavchiku @kgryte @gunjjoshi
feat: add lapack/base/dlassq
350ac1c 
PR-URL: stdlib-js#2668
Ref: stdlib-js#2464
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @kgryte