-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for math/base/special/riemann-zeta
#2737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lib/node_modules/@stdlib/math/base/special/riemann-zeta/include/stdlib/math/base/special/zeta.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
lib/node_modules/@stdlib/math/base/special/riemann-zeta/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/riemann-zeta/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/riemann-zeta/src/main.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Planeshifter This PR needs changes before it can be merged.
lib/node_modules/@stdlib/math/base/special/riemann-zeta/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/riemann-zeta/test/test.native.js
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/riemann-zeta/src/main.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Coverage Report
The above coverage report was generated for the changes in this PR. |
/stdlib merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @gunjjoshi!
lib/node_modules/@stdlib/math/base/special/riemann-zeta/include/stdlib/math/base/special/zeta.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/riemann-zeta/src/addon.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/riemann-zeta/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/riemann-zeta/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/riemann-zeta/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/riemann-zeta/examples/c/example.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed the issue with the header file name. Left a round of comments. Once resolved, I believe this should resolve CI failures and we should be able to merge.
It's not clear to me why |
Description
This pull request:
C
implementation formath/base/special/riemann-zeta
.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers