-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests to blas/ext/base/dnanasum
#3056
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
check the contributing guidelines |
accidently closed PR |
/stdlib merge |
blas/ext/base/dnansumkbn
/stdlib help |
@kgryte, available slash commands include:
|
/stdlib lint-autofix |
Coverage Report
The above coverage report was generated for the changes in this PR. |
@saurabhraghuvanshii Thank you for opening this PR; however, as is, we cannot accept it. The current PR makes several undesired stylistic changes and does not follow our style guidelines or the dominant conventions used throughout the project. While the PR does add additional tests, those cannot be merged until the various stylistic changes are reverted. |
Hii @kgryte if I follow your guidelines of styles and improved it , can be it merged , and sir by mistake I use prettier which change some style. |
@saurabhraghuvanshii Yes, this PR should be on the pathway to being merged. However, you should also see https://github.com/stdlib-js/stdlib/pull/3051/files which implements a very similar set of changes. You should replicate those changes here, but for |
blas/ext/base/dnansumkbn
blas/ext/base/dnansum
@kgryte ok sir |
448c4fb
to
f20f73a
Compare
@kgryte back to Previous Style |
lib/node_modules/@stdlib/blas/ext/base/dnanasum/test/test.dnanasum.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dnanasum/test/test.dnanasum.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
/stdlib lint-autofix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @saurabhraghuvanshii.
blas/ext/base/dnansum
blas/ext/base/dnanasum
@kgryte thanks sir |
Description
This pull request:
Related Issues
This pull request is related to:
blas/ext/base/dnansumkbn
#3046Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers