Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests to blas/ext/base/dnanasum #3056

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

saurabhraghuvanshii
Copy link
Contributor

@saurabhraghuvanshii saurabhraghuvanshii commented Nov 2, 2024

Description

What is the purpose of this pull request?

This pull request:

  • Add test case for blas/ext/base/dnansumk and dnansumk-native.js

Related Issues

Does this pull request have any related issues?

This pull request is related to:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 2, 2024
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@saurabhraghuvanshii
Copy link
Contributor Author

check the contributing guidelines

@saurabhraghuvanshii
Copy link
Contributor Author

accidently closed PR

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib merge

@kgryte kgryte changed the title add-test-case-in-dnansumk-and-in-native test: add tests to blas/ext/base/dnansumkbn Nov 18, 2024
@kgryte kgryte added Duplicate This issue or pull request already exists. Needs Changes Pull request which needs changes before being merged. and removed Duplicate This issue or pull request already exists. labels Nov 18, 2024
@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib help

@stdlib-bot
Copy link
Contributor

@kgryte, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib lint-autofix

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 18, 2024

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dnanasum $\color{green}346/346$
$\color{green}+100.00\%$
$\color{green}13/13$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}346/346$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

@saurabhraghuvanshii Thank you for opening this PR; however, as is, we cannot accept it. The current PR makes several undesired stylistic changes and does not follow our style guidelines or the dominant conventions used throughout the project.

While the PR does add additional tests, those cannot be merged until the various stylistic changes are reverted.

@saurabhraghuvanshii
Copy link
Contributor Author

saurabhraghuvanshii commented Nov 18, 2024

Hii @kgryte if I follow your guidelines of styles and improved it , can be it merged , and sir by mistake I use prettier which change some style.

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

@saurabhraghuvanshii Yes, this PR should be on the pathway to being merged. However, you should also see https://github.com/stdlib-js/stdlib/pull/3051/files which implements a very similar set of changes. You should replicate those changes here, but for blas/ext/base/dnansum.

@kgryte kgryte changed the title test: add tests to blas/ext/base/dnansumkbn test: add tests to blas/ext/base/dnansum Nov 18, 2024
@saurabhraghuvanshii
Copy link
Contributor Author

@kgryte ok sir

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Nov 18, 2024
@saurabhraghuvanshii
Copy link
Contributor Author

saurabhraghuvanshii commented Nov 18, 2024

@kgryte sir , change blas/ext/base/dnansum by refrence #3051 , If any change requires I will do
and Thanks for your valuable time .

@saurabhraghuvanshii
Copy link
Contributor Author

@kgryte back to Previous Style

Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Copy link
Member

kgryte commented Nov 19, 2024

/stdlib lint-autofix

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 19, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @saurabhraghuvanshii.

@kgryte kgryte changed the title test: add tests to blas/ext/base/dnansum test: add tests to blas/ext/base/dnanasum Nov 19, 2024
@kgryte kgryte merged commit 7f76495 into stdlib-js:develop Nov 19, 2024
10 checks passed
@saurabhraghuvanshii
Copy link
Contributor Author

@kgryte thanks sir

@saurabhraghuvanshii saurabhraghuvanshii deleted the test-case branch November 19, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Tests Pull requests specifically adding tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants