Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/cfloorf #3058

Merged
merged 16 commits into from
Nov 11, 2024
Merged

Conversation

aayush0325
Copy link
Contributor

Resolves #649.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Open to reviews!!

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Sorry, something went wrong.

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 3, 2024
@aayush0325
Copy link
Contributor Author

Good Afternoon, can i kindly get your inputs in this @gunjjoshi ?

@aayush0325
Copy link
Contributor Author

have pushed the changes @gunjjoshi , thanks!

@gunjjoshi gunjjoshi changed the title feat: add C implementation for math/base/special/cfloorf feat: add math/base/special/cfloorf Nov 3, 2024
@aayush0325
Copy link
Contributor Author

pushed the changes @gunjjoshi .

@aayush0325 aayush0325 requested a review from gunjjoshi November 8, 2024 07:42
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be close to land (left two comments), thanks for your work on this!

@aayush0325
Copy link
Contributor Author

aayush0325 commented Nov 10, 2024

wasn't exactly sure on how to proceed with this but i tried making some changes to make the benchmark work with stdlib_base_cfloorf, kindly let me know if i should take another approach @Planeshifter

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another review pass; looks good to me. Thank you, @aayush0325!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 11, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `math/base/special/cfloorf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3058
Closes: https://github.com/stdlib-js/stdlib/issues/649

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 6556a46 into stdlib-js:develop Nov 11, 2024
17 checks passed
@aayush0325 aayush0325 deleted the cfloorf branch November 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementations to base special math functions (tracking issue)
4 participants