-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/cfloorf
#3058
Conversation
Good Afternoon, can i kindly get your inputs in this @gunjjoshi ? |
have pushed the changes @gunjjoshi , thanks! |
lib/node_modules/@stdlib/math/base/special/cfloorf/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorf/benchmark/c/Makefile
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorf/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorf/examples/c/Makefile
Outdated
Show resolved
Hide resolved
math/base/special/cfloorf
math/base/special/cfloorf
lib/node_modules/@stdlib/math/base/special/cfloorf/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorf/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorf/include.gypi
Outdated
Show resolved
Hide resolved
pushed the changes @gunjjoshi . |
lib/node_modules/@stdlib/math/base/special/cfloorf/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be close to land (left two comments), thanks for your work on this!
wasn't exactly sure on how to proceed with this but i tried making some changes to make the benchmark work with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did another review pass; looks good to me. Thank you, @aayush0325!
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
Resolves #649.
Description
This pull request:
math/base/special/cfloorf
Related Issues
This pull request:
Questions
No.
Other
Open to reviews!!
Checklist
@stdlib-js/reviewers