Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding tests to achieve 100% coverage for blas/ext/base/dnansumkbn #3066

Closed

Conversation

Neerajpathak07
Copy link
Contributor

@Neerajpathak07 Neerajpathak07 commented Nov 6, 2024

Resolves #3046

Description

This pull request:

  • Adds test case for every file to achieve 100% test coverage for blas/ext/base/dnansumkbn

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 6, 2024
@Neerajpathak07 Neerajpathak07 changed the title test: adding tests to achieve 100% coverage for \blas/ext/base/dnansumkbn\ test: adding tests to achieve 100% coverage for blas/ext/base/dnansumkbn Nov 6, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the tests locally before opening a PR to ensure they work pass and everything works as expected. In this case, will need to remove opts argument from the non-native test files and also fix the arguments passed to the .ndarray methods.

@Neerajpathak07
Copy link
Contributor Author

@Planeshifter Ok I'll run those tests locally while testing and implement the necessary changes.

@Planeshifter
Copy link
Member

@Neerajpathak07 Closing this one in favor of #3051, as that PR can be merged as-is. Thanks either way for your efforts, which are appreciated!

@Neerajpathak07 Neerajpathak07 deleted the test-coverage branch November 12, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete code coverage for blas/ext/base/dnansumkbn
3 participants