feat: add C implementation for math/base/special/minmax

[AbhijitRaut04]

Resolves #2106 .

Description

This PR contains the C implementation for minmax function

This pull request:

• C implementation with benchmarks added in this PR.

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves [RFC]: Add C implementation for @stdlib/math/base/special/minmax #2106

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[AbhijitRaut04]

@Planeshifter Can you please tell me why minmax.h is unable to locate ?

[headlessNode]

@AbhijitRaut04 You don't need to add the "@stdlib/math/base/special/minmax" in the manifest.json file.

Dependencies in manifest.json are for external packages or modules that the code relies on.

By listing ./include in the include path, the manifest.json specifies that any header files within that directory i.e. minmax.h are available.

And since, the C implementation of minmax is not yet implemented listing it in the dependencies is causing the CI errors.

[AbhijitRaut04]

@headlessNode Removed that dependencies but still not working

[headlessNode]

have you run make install-node-addons NODE_ADDONS_PATTERN="math/base/special/minmax" command on your system?

These are compilation errors, if you run the above command on your system you can get a more verbose output to pinpoint the source of the errors. Hope it helps.

[AbhijitRaut04]

running this command gives error

[headlessNode]

Not sure. This could be because of how your environment is configured.

[kgryte]

Maybe try compiling on a newer Node.js version and see if the issue persists. E.g., Node v20 or the latest LTS.

[headlessNode]

@AbhijitRaut04 There are some of inconsistencies in your PR. Namely, the STDLIB_MATH_BASE_NAPI_MODULE_D_D macro is specifically for registering a Node-API module that exports a unary function, one that accepts a single double precision input and returns a double precision output.

To see what macros are available for you see: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/napi

Also, from your lib folder you are missing the native.js file. You are also missing the documentation for the C in the README.

I suggest you go through the similar merged PRs to understand how to implement the C functionality, to start see: #3031

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/minmax	$\color{green}195/195$ $\color{green}+100.00\%$	$\color{green}15/15$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}195/195$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[AbhijitRaut04]

@headlessNode
@kgryte
@Planeshifter
Can you suggest me the updates in pr so that the above issue will get resolved ?

[kgryte]

/stdlib merge

[kgryte]

@AbhijitRaut04 This PR needs some updating. See https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/special/frexp for an example of how to cross from JS to C and back. The difference here will be that minmax is a binary function, not a unary function, but this should be straightforward to accommodate based on the structure of frexp.

[kgryte]

For the C API, we don't need stride and offset. Just provide an *out pointer and assume that the user has provided a two element array.