Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update offset handling and function parameter description for blas/ext/base/dnannsumkbn2 #3123

Merged
merged 5 commits into from
Nov 17, 2024
Merged

refactor: update offset handling and function parameter description for blas/ext/base/dnannsumkbn2 #3123

merged 5 commits into from
Nov 17, 2024

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • update logic to compute output offsetOut
  • fix the function parameter description
  • fix spacing in test files

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 16, 2024
kgryte
kgryte approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte
Copy link
Member

kgryte commented Nov 17, 2024

The failing CI workflow is not due to an issue in this PR. This is caused by the (still) broken cppcheck upgrade.

@kgryte kgryte merged commit f80e82f into stdlib-js:develop Nov 17, 2024
17 of 18 checks passed
@headlessNode headlessNode deleted the dnannsumkbn2-refactor branch November 17, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @kgryte @stdlib-bot