Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/atan2f #3338

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

Neerajpathak07
Copy link
Contributor

@Neerajpathak07 Neerajpathak07 commented Dec 5, 2024

Resolves #649

Description

What is the purpose of this pull request?

This pull request:

  • proposes adding math/base/special/atan2f , which would be a single precision implementation for math/base/special/atan2.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 5, 2024
@Neerajpathak07 Neerajpathak07 marked this pull request as draft December 5, 2024 14:29
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 5, 2024
@Neerajpathak07 Neerajpathak07 changed the title [RFC]: add math/base/special/atan2f feat: add math/base/special/atan2f Dec 5, 2024
@aayush0325
Copy link
Contributor

i see that this PR is failing a lot of tests. you should update your manifest.json to include all the necessary single-precsion dependencies to use them in src/ and lib/ currently you are including double precision dependencies but using the single-precision ones which is why this is causing an error.

@aayush0325
Copy link
Contributor

"dependencies": [
        "@stdlib/math/base/napi/binary",
        "@stdlib/math/base/assert/is-infinitef",
        "@stdlib/math/base/special/copysignf",
        "@stdlib/number/float32/base/signbit",
        "@stdlib/math/base/assert/is-nanf",
        "@stdlib/math/base/special/atanf",
        "@stdlib/constants/float32/pinf",
        "@stdlib/constants/float32/pi"
      ]

this is how you should fill the dependencies in manifest.json

@Neerajpathak07
Copy link
Contributor Author

@aayush0325 thanks for the assist.

@aayush0325
Copy link
Contributor

use number/float32/base/signbit instead of number/float32/base/signbitf as the latter doesn't exist, checkout the package here

@Neerajpathak07
Copy link
Contributor Author

@aayush0325 yeah I understood where I was wrong.
number/float32/base/signbit I was supposed to declare this package and call signbitf as it is the single-precision version of signbit. Also I was writing the tests in double-precision so I'll convert them into single-precision.

@Planeshifter Planeshifter added the status: Blocked Issue or pull request which is current blocked. label Dec 10, 2024
@Planeshifter
Copy link
Member

Planeshifter commented Dec 10, 2024

@Neerajpathak07 The issue here is that @stdlib/number/float32/base/signbit doesn't yet have a C implementation. This PR will have to wait until we have that C implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. status: Blocked Issue or pull request which is current blocked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementations to base special math functions (tracking issue)
4 participants