-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/atan2f
#3338
base: develop
Are you sure you want to change the base?
Conversation
math/base/special/atan2f
math/base/special/atan2f
i see that this PR is failing a lot of tests. you should update your |
"dependencies": [
"@stdlib/math/base/napi/binary",
"@stdlib/math/base/assert/is-infinitef",
"@stdlib/math/base/special/copysignf",
"@stdlib/number/float32/base/signbit",
"@stdlib/math/base/assert/is-nanf",
"@stdlib/math/base/special/atanf",
"@stdlib/constants/float32/pinf",
"@stdlib/constants/float32/pi"
] this is how you should fill the dependencies in |
@aayush0325 thanks for the assist. |
use |
@aayush0325 yeah I understood where I was wrong. |
@Neerajpathak07 The issue here is that |
Resolves #649
Description
This pull request:
math/base/special/atan2f
, which would be a single precision implementation for math/base/special/atan2.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers