Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/negalucasf #3375

Merged
merged 10 commits into from
Dec 15, 2024

Conversation

aayush0325
Copy link
Contributor

@aayush0325 aayush0325 commented Dec 8, 2024

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

  • adds math/base/special/negalucasf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

This branch can be rebased to include constants/float32/max-safe-nth-lucas (in lib/ and src/) and math/base/special/lucasf (in test/) after #3348 and #3337 are merged if needed.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@aayush0325
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. bot: In Progress Pull request is currently awaiting automation. labels Dec 8, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 8, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 8, 2024

Coverage Report

Package Statements Branches Functions Lines
math/base/special/negalucasf $\color{green}225/225$
$\color{green}+100.00\%$
$\color{green}11/11$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}225/225$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @aayush0325!

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 15, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 15, 2024
@Planeshifter Planeshifter merged commit 3b4514d into stdlib-js:develop Dec 15, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants