-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for stats/base/dists/normal/cdf
#3911
base: develop
Are you sure you want to change the base?
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
I am encountering an issue while running the JavaScript benchmark command for the CDF of a normal distribution.
A similar issue also occurs when running the JavaScript benchmark for the CDF of an arcsine distribution which was the reference PR for the current PR feat: add C implementation for arcsine CDF #3354 Can you please help me resolve this? |
stats/base/dists/normal/cdf
@manvith2003 What is the issue? Can you provide a screenshot? One thing is that you need to have first compiled the package's native add-on before you can run the benchmarks. |
Sorry for the confusion, the command in the issues is incorrect since it uses a hard-coded path from my system. The correct command is
so that it uses your current working directory (via Updated: I (Athan) updated this comment and the suggested command to fix a typo. |
After the running the new command also encountering same issue |
@manvith2003 That is because @Planeshifter's suggestion is still incorrect. From the root project directory, make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/normal/cdf/benchmark/benchmark.native.js" I suggest studying the other suggested commands next time and seeing what is different. You likely could have deduced the above by examining the paths and seeing what is different from what you were attempting to run. |
Noted, I’ll review more carefully next time. Thanks! |
Resolves ##3771
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers