Remove trim on result of exec command #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steelbrain
requested changes
Apr 18, 2024
There was a problem hiding this comment.
Hi @kimbob13! Thanks for the PR. Would you be interesting in adding a new noTrim: true | false option instead?
This allows us to cater to most people's needs, as they don't need the extra newline at the end, but for the people who need it, they can turn on the option instead.
|
Thanks for the suggestions! I'll add option instead. |
kimbob13
force-pushed
the
no_trim_cmd_exec
branch
from
87b28ae
to
68edb7c
Compare
|
@steelbrain I've changed to option approach and force pushed. |
steelbrain
approved these changes
Apr 18, 2024
Co-authored-by: Anees Iqbal <hello@aneesiqbal.ai>
|
Warmly reminder, commit added! |
|
Thank you for working on this! I’ll add some tests and make some doc changes before releasing. (Also happy to accept PRs for them ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm using this library to execute command on remote host,
and I want the result to be exactly same as what executed locally.
I think trimming process is a choice of user of library side, not what the library should perform.
Therefore, this PR removes trim method on stdout and stderr results.