Support typescript:main, module, and jsnext:main in package.json

[appsforartists]

In package.json, main refers to a file that uses CommonJS to handle importing/exporting other files. There are other standards for other module formats:

For TypeScript, typescript:main
For ES2015 import/export statements, module and jsnext:main

The relevant Pundle presets (e.g. TypeScript and Babel) should prefer these keys by default.

[steelbrain]

Sounds fair

[appsforartists]

This is especially nice if you're working across many modules. It lets you edit the source of a dependency and still get HMR without needing to run a build step in the middle.

[steelbrain]

Fixed as of 0d7214b
I've added module, but not jsnext:main mainly because it's specific to a package and we want to keep things like that configurable to the user. but module seems more like a standard and also supersedes jsnext:main so that shouldn't be a problem.

[appsforartists]

module seems to work with TypeScript. I tested by importing this module:

appsforartists/MidiConvert@6bdb7de

Want to add it back to the TS preset for beta9?

[steelbrain]

Readded as of 27420f8

[appsforartists]

Using this config in .pundle:

  presets: [
    [
      require.resolve('pundle-preset-default'),
      {
        loader: false,
      }
    ],
    [
      require.resolve('pundle-preset-typescript'),
      {
        resolver: {
          packageMains: ['typescript:main', 'browser', 'main'],
        },
        transformer: {
          extensions: ['js', 'jsx', 'ts', 'tsx'],
          exclude: [],
          config: {
            compilerOptions: Object.assign(
              mainTSConfig.compilerOptions,
              tsConfig.compilerOptions
            )
          }
        }
      }
    ],
  ],

Resolver is seeing this config:

{ alias: {},
  extensions: null,
  packageMains: [ 'browser', 'browserify', 'webpack', 'main' ],
  modulesDirectories: [ 'node_modules' ],
  knownExtensions: [ '', 'js', 'jsx', 'json', 'ts', 'tsx' ] }

In all places that config.packageMains appears in this file:

https://github.com/motion/pundle/blob/f893148bd7e322a36754d9ddc00f5bf80d70bea0/packages/resolver-default/src/index.js#L80

Moving the resolver block into pundle-preset-default corrects packageMains. Are you sure the resolver is looking in other presets for its configuration.

[steelbrain]

In addition to having loader: false, you should also do resolver: false in default preset. The problem is ocurring because default loader is resolving it before it gets to the typescript loader, and exts are the same between the two

[appsforartists]

Adding resolver: false breaks imports:

  Error   Cannot find module './lib/ReactDOM' from 'node_modules/react-dom/index.js'

[steelbrain]

I've put a working pundle configuration for your project in a gist. It doesn't look very nice right now, and is not the most pleasant thing to configure.

I'm going to change that in the upcoming releases so the end user only has to specify extensions or any other config once per preset and the preset can apply that one config at multiple places.

I've opened #117 to track it