Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify FileSystemWatcher to ignore files in config.files.exclude or .p4ignore #63

Merged
merged 2 commits into from
Apr 21, 2017
Merged

modify FileSystemWatcher to ignore files in config.files.exclude or .p4ignore #63

merged 2 commits into from
Apr 21, 2017

Conversation

ihalip
Copy link
Contributor

@ihalip ihalip commented Apr 20, 2017

Should fix #27 and is a good workaround for #62.

Note: this doesn't support multiple file names in P4IGNORE.

@ihalip
Copy link
Contributor Author

ihalip commented Apr 20, 2017

@stef-levesque

@stef-levesque stef-levesque self-requested a review April 20, 2017 13:21
stef-levesque
stef-levesque approved these changes Apr 21, 2017
View reviewed changes
Copy link
Owner

@stef-levesque stef-levesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@stef-levesque stef-levesque merged commit ea9c837 into stef-levesque:master Apr 21, 2017
@ihalip ihalip deleted the ignore-files branch April 26, 2017 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stef-levesque stef-levesque stef-levesque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Honor .p4ignore for delete
2 participants
@ihalip @stef-levesque