Add methods to access raw stdout/stderr logs #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. I would like to add it to System Rules. Do you have time to write the tests for the new feature? |
|
I should be able to write some tests later this week. |
|
I added a basic test that verifies properly handing non-utf-8 data. I would say that proper behaviour with respect to muting, etc. is well covered by the existing tests, do you think something more is needed? |
|
Thanks for adding the test. I do my best to get a release out during next week. |
stefanbirkner
added a commit
to marcvinyals/system-rules
that referenced
this pull request
Nov 1, 2018
This is needed if your application does write binary data or text with a specific charset. Fixes stefanbirkner#66.
stefanbirkner
force-pushed
the
rawstreams
branch
from
cf727f0 to
b807683
Compare
stefanbirkner
added a commit
to marcvinyals/system-rules
that referenced
this pull request
Nov 3, 2018
SystemErrRule and SystemOutRule have a new method "getLogAsBytes" which returns the raw bytes that have been written to System.err/System.out. This is helpful if your application writes binary data or text with a charset that is not the default charset. Fixes stefanbirkner#66.
stefanbirkner
force-pushed
the
rawstreams
branch
from
b807683 to
24a1541
Compare
stefanbirkner
added a commit
to marcvinyals/system-rules
that referenced
this pull request
Nov 6, 2018
SystemErrRule and SystemOutRule have a new method "getLogAsBytes" which returns the raw bytes that have been written to System.err/System.out. This is helpful if your application writes binary data or text with a charset that is not the default charset. Fixes stefanbirkner#66.
stefanbirkner
force-pushed
the
rawstreams
branch
from
24a1541 to
8673706
Compare
stefanbirkner
added a commit
to marcvinyals/system-rules
that referenced
this pull request
Nov 11, 2018
SystemErrRule and SystemOutRule have a new method "getLogAsBytes" which returns the raw bytes that have been written to System.err/System.out. This method can be used for testing applications that write raw binary data. Fixes stefanbirkner#66.
SystemErrRule and SystemOutRule have a new method "getLogAsBytes" which returns the raw bytes that have been written to System.err/System.out. This method can be used for testing applications that write raw binary data. Fixes stefanbirkner#66. Co-authored-by: Stefan Birkner <mail@stefan-birkner.de>
stefanbirkner
force-pushed
the
rawstreams
branch
from
8673706 to
949e687
Compare
|
System Rules 1.19.0 adds a new method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to test some code that writes raw binary data to stdout. To do so I believe I need access to the underlying byte array, since a sequence of bytes may not be a valid string. Therefore I suggest to add a method
getLogBytestoSystemOutRuleandSystemErrRule. Let me know if you think this makes sense and if so I will add documentation and tests to this PR.