Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degraded performance on v1.9.8 on mobile devices #116

Closed
chenghong opened this issue Apr 16, 2018 · 13 comments
Closed

Degraded performance on v1.9.8 on mobile devices #116

chenghong opened this issue Apr 16, 2018 · 13 comments

Comments

@chenghong
Copy link

Tested using v1.9.8 on latest Chrome on Android.

Steps:

  1. Open a datepicker by tapping the parent text box
  2. Close the datepicker by tapping elsewhere on the page
  3. Drag the page a little
  4. Repeat

The datepicker will come to a point where it takes a few seconds to open upon tapping on the parent text box. Expectation is that it should open immediately.

Such performance degradation do not happen on v1.9.7.

@stefangabos
Copy link
Owner

I am unable to reproduce this. Did you use the demo page for testing this?

@chenghong
Copy link
Author

Here is a reduced test case: https://codepen.io/anon/pen/eKodaM

@stefangabos
Copy link
Owner

i am still unable to reproduce it. maybe also tell me the device you are testing this on? i am using browser stack and i can test a lot of devices. there is a small delay but it is there because it waits for the keyboard to open (which scrolls the screen)

@chenghong
Copy link
Author

chenghong commented Jul 3, 2018

I am using Huawei P20 Pro, Chrome browser. Previously was using Huawei P9 and same issue.

Try tapping the icon area situated roughly right-most of the textbox to open the datepicker. It shouldn't bring up the keyboard as there is no text input expected. Tap anywhere else on the white page to close the datepicker. Then scroll the white page a little. Then try open the datepicker again.

@stefangabos
Copy link
Owner

Luckily my own phone is a P9 but I am unable to reproduce this. There is a delay that was introduced in 1.9.8 that is there in order to account for the time it takes for the keyboard to show but it's not getting longer for me even if i tried 20+ times. what i noticed is that if i keep moving (scrolling) the page around a lot and then quickly tap on where the icon should be, it might take a bit longer (like it is waiting for the scrolling to settle) but still the total waiting time is less than a second i think.

don't get me wrong - i'm not saying that this is not happening, i am just saying that i am unable to reproduce it

@chenghong
Copy link
Author

Just wondering, did the keyboard appear for you in any of your tests?

I'll try to create a video if possible.

@stefangabos
Copy link
Owner

Yes, the keyboard appeared every time

@chenghong
Copy link
Author

Here you go: https://www.youtube.com/watch?v=o2gyAa6WoS0

As you can see, no keyboard being activated throughout.
The datepicker only becomes slow to load after the page is dragged around a bit.

@stefangabos
Copy link
Owner

See if this works better, please
https://codepen.io/anon/pen/rKbyNj

stefangabos added a commit that referenced this issue Jul 5, 2018
@chenghong
Copy link
Author

It does appear to solve the original problem, but it introduces a new issue - the page now has a very visible flicker, a few seconds after the page is fully loaded.

@stefangabos
Copy link
Owner

It has to be something else as all I did was to remove a call for setTimeout...it has to be from codepen. I'll do a release soon and then you'll be able to test it with the examples from the demo page

@chenghong
Copy link
Author

Put the code into my actual test page, and am happy to report that the issue is indeed fixed. Thank you!

@stefangabos
Copy link
Owner

Thank you for taking the time to report and helping me test and fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants