-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Degraded performance on v1.9.8 on mobile devices #116
Comments
I am unable to reproduce this. Did you use the demo page for testing this? |
Here is a reduced test case: https://codepen.io/anon/pen/eKodaM |
i am still unable to reproduce it. maybe also tell me the device you are testing this on? i am using browser stack and i can test a lot of devices. there is a small delay but it is there because it waits for the keyboard to open (which scrolls the screen) |
I am using Huawei P20 Pro, Chrome browser. Previously was using Huawei P9 and same issue. Try tapping the icon area situated roughly right-most of the textbox to open the datepicker. It shouldn't bring up the keyboard as there is no text input expected. Tap anywhere else on the white page to close the datepicker. Then scroll the white page a little. Then try open the datepicker again. |
Luckily my own phone is a P9 but I am unable to reproduce this. There is a delay that was introduced in 1.9.8 that is there in order to account for the time it takes for the keyboard to show but it's not getting longer for me even if i tried 20+ times. what i noticed is that if i keep moving (scrolling) the page around a lot and then quickly tap on where the icon should be, it might take a bit longer (like it is waiting for the scrolling to settle) but still the total waiting time is less than a second i think. don't get me wrong - i'm not saying that this is not happening, i am just saying that i am unable to reproduce it |
Just wondering, did the keyboard appear for you in any of your tests? I'll try to create a video if possible. |
Yes, the keyboard appeared every time |
Here you go: https://www.youtube.com/watch?v=o2gyAa6WoS0 As you can see, no keyboard being activated throughout. |
See if this works better, please |
It does appear to solve the original problem, but it introduces a new issue - the page now has a very visible flicker, a few seconds after the page is fully loaded. |
It has to be something else as all I did was to remove a call for setTimeout...it has to be from codepen. I'll do a release soon and then you'll be able to test it with the examples from the demo page |
Put the code into my actual test page, and am happy to report that the issue is indeed fixed. Thank you! |
Thank you for taking the time to report and helping me test and fix it! |
Tested using v1.9.8 on latest Chrome on Android.
Steps:
The datepicker will come to a point where it takes a few seconds to open upon tapping on the parent text box. Expectation is that it should open immediately.
Such performance degradation do not happen on v1.9.7.
The text was updated successfully, but these errors were encountered: