add es3-safe-transpile step #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rjackson |
| @@ -151,7 +152,7 @@ EmberApp.prototype._processedVendorTree = memoize(function() { | |||
| }); | |||
|
|
|||
| EmberApp.prototype.appAndDependencies = memoize(function() { | |||
| var app = this._processedAppTree(); | |||
| var app = new ES3SafeFilter(this._processedAppTree()); | |||
There was a problem hiding this comment.
IMHO, this belongs inside the _processedAppTree function. Moving it out of appAndDependencies makes that function easier to grok (since you can just assume that this thing being pulled in is the processed app tree). In other words, by using a meaningful name (_processedAppTree), you can understand what appAndDependencies is doing without needing to understand the broccoli processing that is done there.
|
👍 - This is awesome! I left a couple comments, and a PR (stefanpenner/es3-safe-recast#1) in the upstream repo. |
|
fixed merged and sync'd. Time to try this on more peoples codez |
currently: ```js promise.finally -> promise[‘finally’] promise.catch -> promise[‘catch’] a.default -> a[‘default’] // and some more.. ``` see: https://github.com/stefanpenner/es3-safe-recast for more
stefanpenner
added a commit
that referenced
this pull request
May 29, 2014
add es3-safe-transpile step
homu
added a commit
that referenced
this pull request
Mar 23, 2016
testem@1.6.0 breaks build⚠️ Hello 👋⚠️ ⚠️ ⚠️ [testem](https://www.npmjs.com/package/testem) just published its new version 1.6.0, which **is covered by your current version range**. After updating it in your project **the build kept failing**. This means **it’s possible that your software is malfunctioning**, because of this update. Use this branch to work on adaptions and fixes. Happy fixing and merging 🌴 --- [GitHub Release](https://github.com/testem/testem/releases/tag/v1.6.0) <h4>Added</h4> <ul> <li> <a href="http://urls.greenkeeper.io/testem/testem/pull/823" class="issue-link js-issue-link" data-url="testem/testem#823" data-id="139111681" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#823</a> in browser <code>afterTests</code> hooks to allow for example coverage instrumentation</li> <li> <a href="http://urls.greenkeeper.io/testem/testem/pull/832" class="issue-link js-issue-link" data-url="testem/testem#832" data-id="140416284" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#832</a> Allow string -1 to be used for parallel config</li> </ul> <h4>Fixed</h4> <ul> <li> <a href="http://urls.greenkeeper.io/testem/testem/pull/822" class="issue-link js-issue-link" data-url="testem/testem#822" data-id="138690475" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#822</a> Cleanup when stopping runners</li> </ul> --- The new version differs by 49 commits . - [`13185e0`](testem/testem@13185e0) `1.6.0` - [`da027e6`](testem/testem@da027e6) `Merge pull request #838 from johanneswuerbach/travis-os-x-node` - [`e8c60a6`](testem/testem@e8c60a6) `Use new travis OS X node support` - [`e911120`](testem/testem@e911120) `Merge pull request #832 from trentmwillis/neg-one` - [`7b68528`](testem/testem@7b68528) `Allow string -1 to be used for parallel config` - [`9b7850c`](testem/testem@9b7850c) `Merge pull request #829 from johanneswuerbach/after-tests-hook-for-browser-tap` - [`33fbc97`](testem/testem@33fbc97) `Merge pull request #828 from johanneswuerbach/travis-retry` - [`5884547`](testem/testem@5884547) `Fixes run afterTests hook for browser tap` - [`f1aec95`](testem/testem@f1aec95) `CI: Disable npm spinner` - [`96aa47a`](testem/testem@96aa47a) `AppVeyor: Retry all the things` - [`eb32cb2`](testem/testem@eb32cb2) `Travis: Retry all the things` - [`29da503`](testem/testem@29da503) `Merge pull request #822 from johanneswuerbach/cleanup-with-runner-stopping` - [`dfdf0a9`](testem/testem@dfdf0a9) `Merge pull request #823 from jreading/afterTestsCallback` - [`a690bfa`](testem/testem@a690bfa) `update to support asynchronous callbacks from the browser` - [`c489655`](testem/testem@c489655) `Cleanup when stopping runners` There are 49 commits in total. See the [full diff](testem/testem@6d8507b...13185e0). --- This pull request was created by [greenkeeper.io](http://greenkeeper.io/). It keeps your software, up to date, all the time. <sub> Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡ </sub>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently just:
promise.finally->promise[‘finally’]promise.catch->promise[‘catch’]a.default->a[‘default’]and the object literal versions
The transpile step stuff support source maps but the rest of our pipeline doesn't quite yet.
related:
https://github.com/stefanpenner/es3-safe-recast/
https://github.com/stefanpenner/broccoli-es3-safe-recast/