Allow casting without input containing catch/finally. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RegExp that was used as a quick check filter was only looking for `catch` and `finally`. This meant that it would not recast any of the other identifiers if `catch`/`finally` did not also exist in the output. Changes: * Added tests for the individual literals (in both object literal and object member formats). * Build the RegExp dynamically based on the actual literals being matched. This could have been done inline, but I believe that we will likely have other scenarios to check, and will likely need to have the ability to construct more complicationed RegExps anyways.
|
Good catch |
stefanpenner
added a commit
that referenced
this pull request
May 27, 2014
Allow casting without input containing catch/finally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RegExp that was used as a quick check filter was only looking for
catchandfinally. This meant that it would not recast any of the other identifiers ifcatch/finallydid not also exist in the input.Changes: