Use TCP_NODELAY for TCP connections (#26)

stefantalpalaru · May 10, 2024 · 009ed45 · 009ed45
1 parent f85cd7e
commit 009ed45
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -2,8 +2,9 @@
 
 ### All Platforms
 - Set up a Transifex project to manage translations ([#20](https://github.com/stefantalpalaru/transmission-og/pull/20))
-- use clang-format to automate code formatting ([#22](https://github.com/stefantalpalaru/transmission-og/pull/22))
+- Use clang-format to automate code formatting ([#22](https://github.com/stefantalpalaru/transmission-og/pull/22))
 - Windows: remove MSI installer ([#24](https://github.com/stefantalpalaru/transmission-og/pull/24))
+- Use TCP\_NODELAY for TCP connections ([#26](https://github.com/stefantalpalaru/transmission-og/pull/26))
 
 ### Mac Client
 - Update Sparkle to 2.6.2, to allow building on ARM64 macOS ([#25](https://github.com/stefantalpalaru/transmission-og/pull/25))

diff --git a/libtransmission/net.c b/libtransmission/net.c
@@ -440,15 +440,19 @@ static tr_socket_t tr_netBindTCPImpl(tr_address const *addr, tr_port port, bool
         tr_logAddDebug("Bound socket %" PRIdMAX " to port %d on %s", (intmax_t)fd, port, tr_address_to_string(addr));
     }
 
-#ifdef TCP_FASTOPEN
-
+// for macOS: https://github.com/unbit/uwsgi/pull/966
 #ifndef SOL_TCP
 #define SOL_TCP IPPROTO_TCP
 #endif
 
+#ifdef TCP_FASTOPEN
     optval = 5;
     setsockopt(fd, SOL_TCP, TCP_FASTOPEN, (void const *)&optval, sizeof(optval));
+#endif
 
+#ifdef TCP_NODELAY
+    optval = 1;
+    setsockopt(fd, SOL_TCP, TCP_NODELAY, (void const *)&optval, sizeof(optval));
 #endif
 
     if (listen(fd, 128) == -1) {