Horizon: Protocol 19 Integration Tests

[Shaptic]

Breakdown and Rollout: Horizon & Protocol 19. See #4261 for the master issue.

---

Now that Protocol 19 feature work is mostly complete in the horizon-protocol-19 branch and the Go SDK is up-to-date, we can turn our focus to stability. We need end-to-end integration tests for the new features:

• Generating full account extensions for state verifier tests (Uncomment StateVerifier test that generates account v3 extensions #4304)
• Add stellar-core builds that include Protocol 19 work (horizon: Set up protocol 19 integration tests infrastructure #4312)
• Test new CAP-21 account fields (horizon: Add integration test for new protocol 19 account fields #4322)
• Test new transaction preconditions (Add integration test for extra signers using tx preconditions #4320)
• Test transaction submission queue (horizon: Add transaction submission test for Protocol 19 #4327)
• Add state verifier tests for all of the above
• Test Starlight (Leigh)

[jcx120]

Are there tests we should include for regressing re-ingestion and regular ingestion to keep up with ledger?

[Shaptic]

@jcx120 added an item re: state verifier. I think we get regression testing "automatically" by running our test suite without an actual Protocol 19 build of Stellar Core (aka what's been happening until #4306 gets merged), but moving forward yes, we need to ensure each new feature has the relevant ingestion testing (I think it did in their individual PRs).

[2opremio]

Add state verifier tests for all of the above

@Shaptic how do you suggest we do this? Changing TestStateVerifier to submit transactions with preconditions? Or are you just referring to the new Account fields?

Because I think the latter is already implicitly tested.

[2opremio]

Test new transaction preconditions

I think this is almost done, just a few fields left. @sreuland are you on top of it? (since you where already adding tests for other preconditions)

[sreuland]

I think this is almost done, just a few fields left. @sreuland are you on top of it? (since you where already adding tests for other preconditions)

There are couple tests remaining, started working on coverage for LedgerBounds, MinSequenceNumberAge, MinSequenceLedgerNumberGap in Preconditions.

Also, noticed the xdr files changed recently on core p19 branch such as Stellar-transaction.x. Do we need to sync up to those?

[sreuland]

@2opremio , PR #4332 is up for new integration test coverage on those remaining transaction preconditions.

[Shaptic]

@2opremio You're right that account extensions were supposed to have been tested! And preconditions aren't part of state, so we don't need to test those.

Unfortunately, the account extensions actually weren't tested after #4304 because this line:

{randxdr.FieldEquals("created.data.account.ext.v1.ext.v2.ext.v"), randxdr.SetU32(0)},

kept the extension disabled and I didn't realize that during the review 🤦

This is resolved by #4337.