txnbuild: Initialise transaction envelope in build #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OwenJacob this looks good. Can you rebase this to |
|
@poliha I've fixed the gofmt issue. I see another CI test has failed presumably because my fork or branch or something is behind |
Instead of building the transaction envelope at the start of Sign we can do this at the end of build. This allows an unsigned envelope to be returned for signing offline/elsewhere Fix for: stellar#956
|
@poliha think I got it right now :) |
oryband
pushed a commit
to kinecosystem/go
that referenced
this pull request
Jul 22, 2019
Instead of building the transaction envelope at the start of Sign we can do this at the end of build. This allows an unsigned envelope to be returned for signing offline/elsewhere Fix for: stellar#956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building the transaction envelope at the start of Sign we can do this at the end of build. This allows an unsigned envelope to be returned for signing offline/elsewhere
Fix for: #956
This is my first ever PR on Github so hopefully I got this bit right :)