Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circleci: Fix CircleCI OOM errors #1633

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Aug 22, 2019

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Summary

Occasionally CircleCI jobs triggered by PRs fail because of OOM errors (see https://circleci.com/gh/stellar/go/6268#usage-queue/containers/0 for an example). The cause and fix for this issue is outlined here:

golang/go#26186 (comment)

Copy link
Member

@accordeiro accordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! :)

@bartekn
Copy link
Contributor

bartekn commented Aug 22, 2019

Great, thanks!

@tamirms tamirms merged commit 472f6d0 into stellar:master Aug 22, 2019
@tamirms tamirms deleted the circle-ci-oom branch August 22, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants