Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Resume ingestion immediately when catching up #4196

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jan 25, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

When more than one ingesting instances is running and the current one is behind, go to resumeState immediately instead of after 1s. Waiting 1s can slow down make applying ledgers by Captive-Core slower in catching-up mode.

@bartekn bartekn marked this pull request as ready for review January 25, 2022 18:41
@bartekn bartekn requested a review from a team January 25, 2022 18:41
@bartekn bartekn merged commit d3ce98c into stellar:master Jan 28, 2022
@bartekn bartekn deleted the resume-immediately-when-catching-up branch January 28, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants